Revert to previous androidx core version (1.8.0)#1640
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
==========================================
- Coverage 83.46% 83.44% -0.03%
==========================================
Files 221 221
Lines 7474 7476 +2
Branches 1049 1050 +1
==========================================
Hits 6238 6238
- Misses 826 827 +1
- Partials 410 411 +1 ☔ View full report in Codecov by Sentry. |
joshdholtz
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #1622, we updated to androidx core 1.12.0 which increased the target version to 34. This however, brought some problems in some of the hybrids: RevenueCat/purchases-capacitor#211.
This update was to access some optional method that we can easily implement ourselves, so we are reverting that update and implementing the fallback for registering the receiver ourselves.
We will add additional checks to avoid inadvertently upgrading the target version.