Release 6.9.7#1638
Conversation
tonidero
left a comment
There was a problem hiding this comment.
Just a concern... but maybe we can fix the file after releasing this?
| command: aws s3 sync ~/project/docs/6.9.7 s3://purchases-docs/android/6.9.7 --delete | ||
| - run: | ||
| name: Update index.html | ||
| command: aws s3 cp ~/project/docs/index.html s3://purchases-docs/android/index.html |
There was a problem hiding this comment.
Hmm I just noticed but would this make the 6.9.7 docs the default ones? If so, we would need to either fix it so we don't overwrite the file if the versions is older than the one already there, or overwrite this file after publishing this
There was a problem hiding this comment.
ouch, yes, that's actually a bit complex to automate 🤔
fyi, I had to update the version number manually, because the lane tries to get the difference agains the latest version published, not the latest version within the same major, we need to fix that too...
Fine if I remove that step for now?
There was a problem hiding this comment.
Yup! We can remove that for now 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.9.6 #1638 +/- ##
==============================================
Coverage 85.93% 85.93%
==============================================
Files 184 184
Lines 6277 6277
Branches 911 911
==============================================
Hits 5394 5394
Misses 536 536
Partials 347 347 ☔ View full report in Codecov by Sentry. |
Adding #1638 to changelog in main
Bugfixes