Paywalls: Add paywall events flush logic and tests (3)#1445
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
+ Coverage 83.95% 84.03% +0.08%
==========================================
Files 203 206 +3
Lines 6712 6842 +130
Branches 974 993 +19
==========================================
+ Hits 5635 5750 +115
- Misses 697 706 +9
- Partials 380 386 +6
☔ View full report in Codecov by Sentry. |
NachoSoto
approved these changes
Nov 8, 2023
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
Looks great!
I want to make sure this handles (and tests) a specific use case that's tested in iOS:
See PaywallEventStoreTests.testFetchEventsWithUnrecognizedLines:
That's basically testing that this code:
return try await self.handler.readLines()
.prefix(count)
.compactMap { try? PaywallEventSerializer.decode($0) }Is written like that, instead of
return try await self.handler.readLines()
.compactMap { try? PaywallEventSerializer.decode($0) }
.prefix(count)Notice prefix happens first
So that if invalid lines are found, they still get removed from the store.
Contributor
Author
|
Nope, I didn't have that logic. Thanks for mentioning it! I will fix that and add some tests tomorrow |
Contributor
Author
|
Made changes to handle this in #1451 |
Base automatically changed from
toniricodiez/pwl-321-paywall-events-2
to
main
November 10, 2023 08:53
6dbfdc1 to
795838c
Compare
tonidero
pushed a commit
that referenced
this pull request
Nov 10, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: improve error log when images fail to load (#1454) via NachoSoto (@NachoSoto) ### Other Changes * Paywall events: Send paywall data with post receipt requests (#1452) via Toni Rico (@tonidero) * Paywalls: Track paywall events (#1447) via Toni Rico (@tonidero) * Paywall events: Handle errors parsing specific paywall event lines (#1451) via Toni Rico (@tonidero) * Paywalls: Move logic for events file helper to common generic class (4) (#1446) via Toni Rico (@tonidero) * Paywalls: Add paywall events flush logic and tests (3) (#1445) via Toni Rico (@tonidero) * Paywalls: Support sending paywall events to servers (2) (#1442) via Toni Rico (@tonidero) * `CircleCI`: fix `record-revenuecatui-snapshots` (#1455) via NachoSoto (@NachoSoto) * Lower request jitter log level from warning to debug (#1453) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the code to the
PaywallEventsManagerclass to actually send the events to the backend and clear them locally once finished.