Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (6311b24) to head (fbd2b47).
Report is 317 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
- Coverage   84.13%   84.09%   -0.05%     
==========================================
  Files         197      197              
  Lines        6649     6644       -5     
  Branches      965      964       -1     
==========================================
- Hits         5594     5587       -7     
+ Misses        684      683       -1     
- Partials      371      374       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I think this makes sense. Have you tested the case of closing purchases then configuring again? We only reset the listener when closing purchases, so it's the only point where I think it could be problematic. Not sure how many people use that, but might be good to confirm it reconnects ok.

I haven't tested it, I will. I noticed though, that the close function does call endConnection after setting the listener to null, so I don't think there's any difference there:

fun close() {
        purchasesUpdatedListener = null
        endConnection()
}

Before this change, we were actually calling endConnection twice when calling close (one when setting the listener to null as a side effect and one directly in close)

It works @tonidero , I configured, then ended connection then configured and it works fine