Paywalls: new {{ sub_relative_discount }} variable#1425
Merged
Conversation
2561e60 to
8e843ab
Compare
NachoSoto
commented
Nov 1, 2023
Contributor
Author
There was a problem hiding this comment.
Extracted this because LongMethod lint instead of suppressing the lint
8e843ab to
1337d4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 197 197
Lines 6626 6626
Branches 960 960
=======================================
Hits 5584 5584
Misses 674 674
Partials 368 368 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Nov 2, 2023
| VariableProcessor.Context(discountRelativeToMostExpensivePerMonth), | ||
| localization, | ||
| it, | ||
| locale, |
Member
There was a problem hiding this comment.
can you add names to the parameters here?
tonidero
approved these changes
Nov 2, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
LGTM after addressing those comments
NachoSoto
pushed a commit
that referenced
this pull request
Nov 6, 2023
**This is an automatic release.** ### New Features * `StoreProduct`: new `pricePerWeek` and `pricePerYear` (#1426) via NachoSoto (@NachoSoto) ### RevenueCatUI * Fix RevenueCatUI API issues and add API tests (#1433) via Toni Rico (@tonidero) * Paywalls: Add initial snapshot testings for RevenueCatUI library (#1432) via Toni Rico (@tonidero) * `Paywalls`: new `{{ sub_price_per_week }}` variable (#1427) via NachoSoto (@NachoSoto) * `Paywalls`: new `{{ sub_relative_discount }}` variable (#1425) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `a297205` to `0ddee10` (#1431) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `Offering`: restore constructor with no `PaywallData` (#1437) via NachoSoto (@NachoSoto) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent to RevenueCat/purchases-ios#3131