Refactor checking for available packages when creating package configuration#1307
Merged
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paywalls #1307 +/- ##
=========================================
Coverage 85.06% 85.06%
=========================================
Files 193 193
Lines 6475 6475
Branches 942 942
=========================================
Hits 5508 5508
Misses 600 600
Partials 367 367 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Oct 4, 2023
| availablePackages = availablePackages, | ||
| activelySubscribedProductIdentifiers = activelySubscribedProductIdentifiers, | ||
| filter = packageIds, | ||
| packageIdsInConfig = paywallData.config.packages, |
Contributor
There was a problem hiding this comment.
I wonder if we should rename the property packages to packageIds, even if the backend response remains the same... But that can be done separately if needed.
Member
Author
There was a problem hiding this comment.
That will make things clearer. I will open a PR
…venuecatui/data/processed/PackageConfigurationFactory.kt Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
This was referenced Oct 16, 2023
tonidero
added a commit
that referenced
this pull request
Oct 31, 2023
…uration (#1307) Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There shouldn't be any behavior change, but this refactor makes it more clear what happens when none of the configured packages are available.