CustomEntitlementComputation: Configure method for customEntitlementComputation mode by tonidero · Pull Request #1168 · RevenueCat/purchases-android

tonidero · 2023-07-24T08:56:44Z

Description

Add new configureInCustomEntitlementsComputationMode method to configure the SDK in this mode. This will replace configuring the SDK with a special PurchasesConfiguration object simplifying configuration for this mode

tonidero · 2023-07-24T08:57:57Z

+                .service(executorService)
+                .diagnosticsEnabled(true)
+                .entitlementVerificationMode(EntitlementVerificationMode.INFORMATIONAL)
+                .build();


This isn't really needed for the customEntitlementComputation flavor, but moving api tests to the main source set since now this class will be common for both.

tonidero · 2023-07-24T08:59:42Z

        @JvmStatic
-        fun configure(
-            configuration: PurchasesConfiguration,
+        fun configureInCustomEntitlementsComputationMode(


This means that in this mode, anything else that can be enabled in PurchasesConfiguration won't be available, like setting a custom executorService for requests, observer mode, entitlement verification mode.... This is ok for now, but I wanted to mention it.

Yup we want to be very opinionated for this mode 👍🏻

codecov · 2023-07-24T09:09:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (3a43a81) to head (752dd9a).
Report is 562 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   85.59%   85.61%   +0.02%     
==========================================
  Files         179      180       +1     
  Lines        6121     6181      +60     
  Branches      918      919       +1     
==========================================
+ Hits         5239     5292      +53     
- Misses        540      547       +7     
  Partials      342      342

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NachoSoto · 2023-07-24T09:09:31Z

-                .build();
-
-        Purchases.configure(build);
+        Purchases.configureInCustomEntitlementsComputationMode(context, "", "");


NachoSoto

I see this as a benefit more than a downside 👍🏻 we want to have complete control of this configuration rather than allowing anything.

NachoSoto · 2023-07-24T09:09:53Z

    static void checkConfiguration(final Context context,
-                                   final ExecutorService executorService) {
+                                   final ExecutorService executorService,
+                                   final PurchasesConfiguration purchasesConfiguration) {


Cleaner since this is already tested 👍🏻

NachoSoto · 2023-07-24T09:10:39Z

        @JvmStatic
-        fun configure(
-            configuration: PurchasesConfiguration,
+        fun configureInCustomEntitlementsComputationMode(


Yup we want to be very opinionated for this mode 👍🏻

@aboedo

**This is an automatic release.** ### New Features Introduced Custom Entitlements Computation mode. This is new library intended for apps that will do their own entitlement computation separate from RevenueCat. It's distributed as a separate artifact in Maven. Apps using this mode rely on webhooks to signal their backends to refresh entitlements with RevenueCat. See the [demo app for an example and usage instructions](https://github.com/RevenueCat/purchases-android/tree/main/examples/CustomEntitlementComputationSample). * Custom entitlements: add README and other improvements (#1167) via Andy Boedo (@aboedo) * Update Custom Entitlements Sample app (#1166) via Andy Boedo (@aboedo) * purchase coroutine (#1142) via Andy Boedo (@aboedo) * Add switchUser (#1156) via Cesar de la Vega (@vegaro) * CustomEntitlementsComputation: disable first listener callback when set (#1152) via Andy Boedo (@aboedo) * CustomEntitlementsComputation: Prevent posting subscriber attributes in post receipt (#1151) via Andy Boedo (@aboedo) * Fix `customEntitlementComputation` library deployment (#1169) via Toni Rico (@tonidero) * CustomEntitlementComputation: Configure method for customEntitlementComputation mode (#1168) via Toni Rico (@tonidero) * Add publish system for customEntitlementComputation package (#1149) via Cesar de la Vega (@vegaro) * Use purchase coroutine in CustomEntitlementComputationSample (#1162) via Cesar de la Vega (@vegaro) * Adds CustomEntitlementComputationSample (#1160) via Cesar de la Vega (@vegaro) * Fix tests in customEntitlementComputation after merges (#1161) via Toni Rico (@tonidero) * CustomEntitlementComputation: Remove custom entitlement computation flavor for amazon module (#1158) via Toni Rico (@tonidero) * CustomEntitlementComputation: Generate dokka docs only for defaults flavor (#1159) via Toni Rico (@tonidero) * CustomEntitlementComputation: Create different PurchasesConfiguration that requires an appUserId parameter (#1154) via Toni Rico (@tonidero) * CustomEntitlementComputation: New Purchases class (#1153) via Toni Rico (@tonidero) * CustomEntitlementComputation: Disable automatic cache refresh (#1157) via Toni Rico (@tonidero) * Add `customEntitlementComputation` flavor (#1147) via Toni Rico (@tonidero) * Make `customEntitlementComputation` singular (#1148) via Toni Rico (@tonidero) * Disable offline entitlements in custom entitlements computation mode (#1146) via Toni Rico (@tonidero) * Remove integration test flavor (#1143) via Toni Rico (@tonidero) * Add header to requests when in custom entitlement computation mode (#1145) via Toni Rico (@tonidero) * Add internal customEntitlementsComputation mode to app config (#1141) via Toni Rico (@tonidero) ### New Coroutines * `awaitPurchase` is available as a coroutine-friendly alternative to `purchase()`. (#1142) via Andy Boedo (@aboedo) ### Dependency Updates * Bump fastlane from 2.213.0 to 2.214.0 (#1140) via dependabot[bot] (@dependabot[bot]) ### Other changes * CI: make all Codecov jobs informational (#1155) via Cesar de la Vega (@vegaro) * Creates PurchasesOrchestrator (#1144) via Cesar de la Vega (@vegaro) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Andy Boedo <andresboedo@gmail.com>

@aboedo

### New Features Introduced Custom Entitlements Computation mode. This is new library intended for apps that will do their own entitlement computation separate from RevenueCat. It's distributed as a separate artifact in Maven. Apps using this mode rely on webhooks to signal their backends to refresh entitlements with RevenueCat. See the [demo app for an example and usage instructions](https://github.com/RevenueCat/purchases-android/tree/main/examples/CustomEntitlementComputationSample). * Custom entitlements: add README and other improvements (#1167) via Andy Boedo (@aboedo) * Update Custom Entitlements Sample app (#1166) via Andy Boedo (@aboedo) * purchase coroutine (#1142) via Andy Boedo (@aboedo) * Add switchUser (#1156) via Cesar de la Vega (@vegaro) * CustomEntitlementsComputation: disable first listener callback when set (#1152) via Andy Boedo (@aboedo) * CustomEntitlementsComputation: Prevent posting subscriber attributes in post receipt (#1151) via Andy Boedo (@aboedo) * Fix `customEntitlementComputation` library deployment (#1169) via Toni Rico (@tonidero) * CustomEntitlementComputation: Configure method for customEntitlementComputation mode (#1168) via Toni Rico (@tonidero) * Add publish system for customEntitlementComputation package (#1149) via Cesar de la Vega (@vegaro) * Use purchase coroutine in CustomEntitlementComputationSample (#1162) via Cesar de la Vega (@vegaro) * Adds CustomEntitlementComputationSample (#1160) via Cesar de la Vega (@vegaro) * Fix tests in customEntitlementComputation after merges (#1161) via Toni Rico (@tonidero) * CustomEntitlementComputation: Remove custom entitlement computation flavor for amazon module (#1158) via Toni Rico (@tonidero) * CustomEntitlementComputation: Generate dokka docs only for defaults flavor (#1159) via Toni Rico (@tonidero) * CustomEntitlementComputation: Create different PurchasesConfiguration that requires an appUserId parameter (#1154) via Toni Rico (@tonidero) * CustomEntitlementComputation: New Purchases class (#1153) via Toni Rico (@tonidero) * CustomEntitlementComputation: Disable automatic cache refresh (#1157) via Toni Rico (@tonidero) * Add `customEntitlementComputation` flavor (#1147) via Toni Rico (@tonidero) * Make `customEntitlementComputation` singular (#1148) via Toni Rico (@tonidero) * Disable offline entitlements in custom entitlements computation mode (#1146) via Toni Rico (@tonidero) * Remove integration test flavor (#1143) via Toni Rico (@tonidero) * Add header to requests when in custom entitlement computation mode (#1145) via Toni Rico (@tonidero) * Add internal customEntitlementsComputation mode to app config (#1141) via Toni Rico (@tonidero) ### New Coroutines * `awaitPurchase` is available as a coroutine-friendly alternative to `purchase()`. (#1142) via Andy Boedo (@aboedo) ### Dependency Updates * Bump fastlane from 2.213.0 to 2.214.0 (#1140) via dependabot[bot] (@dependabot[bot]) ### Other changes * CI: make all Codecov jobs informational (#1155) via Cesar de la Vega (@vegaro) * Creates PurchasesOrchestrator (#1144) via Cesar de la Vega (@vegaro) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Andy Boedo <andresboedo@gmail.com>

tonidero added 2 commits July 24, 2023 10:52

Configure method for customEntitlementComputation mode

32acb77

Rename method to same name as iOS

752dd9a

tonidero added the refactor label Jul 24, 2023

tonidero commented Jul 24, 2023

View reviewed changes

tonidero marked this pull request as ready for review July 24, 2023 09:00

tonidero requested a review from a team July 24, 2023 09:00

NachoSoto reviewed Jul 24, 2023

View reviewed changes

NachoSoto approved these changes Jul 24, 2023

View reviewed changes

tonidero mentioned this pull request Jul 24, 2023

Custom entitlements: add README and other improvements #1167

Merged

tonidero merged commit 9d3e882 into main Jul 24, 2023

tonidero deleted the toni/configure-custom-entitlement-mode-configure-method branch July 24, 2023 09:46

RCGitBot mentioned this pull request Jul 24, 2023

[AUTOMATIC] Release/6.8.0 #1170

Merged

RCGitBot mentioned this pull request Jul 24, 2023

[AUTOMATIC] Release/6.8.0 #1173

Merged

vegaro added pr:other and removed pr:refactor labels Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CustomEntitlementComputation: Configure method for customEntitlementComputation mode#1168

CustomEntitlementComputation: Configure method for customEntitlementComputation mode#1168
tonidero merged 2 commits into
mainfrom
toni/configure-custom-entitlement-mode-configure-method

tonidero commented Jul 24, 2023

Uh oh!

tonidero Jul 24, 2023

Uh oh!

tonidero Jul 24, 2023

Uh oh!

NachoSoto Jul 24, 2023

Uh oh!

codecov Bot commented Jul 24, 2023 •

edited

Loading

Uh oh!

NachoSoto Jul 24, 2023

Uh oh!

NachoSoto left a comment

Uh oh!

NachoSoto Jul 24, 2023

Uh oh!

NachoSoto Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tonidero commented Jul 24, 2023

Description

Uh oh!

tonidero Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

tonidero Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NachoSoto Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto left a comment

Choose a reason for hiding this comment

Uh oh!

NachoSoto Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 24, 2023 •

edited

Loading