Skip to content

Trusted entitlements: Improve signature verification error log#1132

Merged
tonidero merged 4 commits into
mainfrom
improve-signature-verification-error-log
Jul 11, 2023
Merged

Trusted entitlements: Improve signature verification error log#1132
tonidero merged 4 commits into
mainfrom
improve-signature-verification-error-log

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

This adds a link to the trusted entitlements page in the docs when there is a signature verification error. This will help users get more data about the issue immediately without having to contact support.

@tonidero tonidero added the docs label Jul 11, 2023
@tonidero tonidero requested a review from a team July 11, 2023 15:01
@codecov

codecov Bot commented Jul 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1132 (5ef1455) into main (373f94b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5ef1455 differs from pull request most recent head f20eea7. Consider uploading reports for the commit f20eea7 to get more accurate results

@@           Coverage Diff           @@
##             main    #1132   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         175      175           
  Lines        6112     6114    +2     
  Branches      902      902           
=======================================
+ Hits         5216     5218    +2     
  Misses        554      554           
  Partials      342      342           
Impacted Files Coverage Δ
...src/main/kotlin/com/revenuecat/purchases/errors.kt 100.00% <100.00%> (ø)

Comment on lines +60 to +63
SignatureVerificationError(
36,
"Request failed signature verification. Please see https://rev.cat/trusted-entitlements for more info.",
),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh I'm gonna do this too.

@tonidero tonidero enabled auto-merge (squash) July 11, 2023 16:47
NachoSoto added a commit to RevenueCat/purchases-ios that referenced this pull request Jul 11, 2023
@tonidero tonidero merged commit d407042 into main Jul 11, 2023
@tonidero tonidero deleted the improve-signature-verification-error-log branch July 11, 2023 16:55
@vegaro vegaro added pr:other and removed pr:docs labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants