Trusted entitlements: Remove decoding of url to verify signatures#1124
Merged
tonidero merged 1 commit intoJul 7, 2023
Merged
Conversation
bisho
approved these changes
Jul 7, 2023
aboedo
reviewed
Jul 7, 2023
Comment on lines
+195
to
+205
| fun `verifyResponse with encoded url verifies correctly`() { | ||
| val rootVerifier = DefaultSignatureVerifier("yg2wZGAr8Af+Unt9RImQDbL7qA81txk+ga0I+ylmcyo=") | ||
| val signingManager = SigningManager( | ||
| SignatureVerificationMode.Informational(IntermediateSignatureHelper(rootVerifier)), | ||
| appConfig, | ||
| apiKey, | ||
| ) | ||
| val verificationResult = callVerifyResponse( | ||
| signingManager, | ||
| requestPath = "/v1/subscribers/\$RCAnonymousID%3A1af512a3b9c848899fe427f39dd69f2b", | ||
| signature = "xoDYyUeHnIlSIAeOOzmvdNPOlbNSKK+xE0fE/ufS1fsAAMNQ1HiPDL34Vx0Uy74KPV5mztuk3DHBpucT/rSYVlkxIa3ModYmPfYZ20lnlbSB1UiP6oJHwAA2pXlS6AQ5eLSuAmm2UIYPrDGEEC8Lgj1sAn2fGMRMx2eaPNzDPBGTxxZROfjkI1wtsyJC0w0I7d8TkLeXjUTlWNafmc4GVMleE/tQZZGIoNrnar0HqICUnB8B", |
Member
There was a problem hiding this comment.
just double-checking, these were obtained with a signature that isn't set to expire, right? Otherwise, are we ensuring that these won't go stale when the intermediate key goes stale?
Contributor
Author
There was a problem hiding this comment.
I generated these with a date very far into the future (Year 2106) so they shouldn't expire. Since we aren't using real keys for these tests, it should be ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We made one more change to the signature verification. Now we don't need to decode the url in order to verify the signature.