Compose sample app by tonidero · Pull Request #1056 · RevenueCat/purchases-android

tonidero · 2023-06-07T15:08:53Z

Description

This PR adds a new sample app MagicWeatherCompose, very similar to the existing MagicWeather but using Jetpack Compose. Many things are copied over from MagicWeather including the actual weather change logic and the purchase SDK setup. It does change how we interact with the SDK from there.

To better understand the code, this app has 2 main screens:

Main
Paywall

The Main screen has a bottom navigation view and has 2 subscreens, Weather and User.

This can be a better sample for more modern android development. Things remaining:

Build app on every PR, to make sure it compiles.
Improve UI
Use coroutines
Add some global state instead of always performing getCustomerInfo, so we can use it to listen to the customer info listener.

device-2023-06-07-170206.mp4

tonidero · 2023-06-07T15:09:29Z

I copied this from the existing MagicWeather to be able to run it with both Google and Amazon.

tonidero · 2023-06-07T15:19:28Z

I tried to do this in a way that it could be extracted to a library in the future if needed 😏 . Made an assumption by using architecture component view models, which we could potentially remove, but this is how I imagine a view that can just be used by anyone using jetpack compose. cc @RevenueCat/coresdk

asks ChatGPT what "architecture component view models" means

tonidero · 2023-06-07T15:25:55Z

All this is mostly copied from the existing MagicWeather

codecov · 2023-06-07T15:39:49Z

Codecov Report

Merging #1056 (8ceb316) into main (9f617e1) will not change coverage.
The diff coverage is n/a.

❗ Current head 8ceb316 differs from pull request most recent head 5ab1901. Consider uploading reports for the commit 5ab1901 to get more accurate results

@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files         179      179           
  Lines        6362     6362           
  Branches      876      876           
=======================================
  Hits         5463     5463           
  Misses        557      557           
  Partials      342      342

tonidero · 2023-06-08T08:41:10Z

Ideally we would improve the UI to also display free trials and what not. But as a sample app it's functional for now.,

we can always iterate as we feel the need

tonidero · 2023-06-08T08:42:02Z

This are the default app icons for a template app. Could customize them but don't want to dedicate more time to a sample app

aboedo · 2023-06-21T13:40:56Z

aboedo · 2023-06-21T13:42:32Z

this is pretty much exactly like SwiftUI, love it

honestly kinda better syntax

aboedo · 2023-06-21T13:44:17Z

asks ChatGPT what "architecture component view models" means

aboedo · 2023-06-21T13:45:01Z

aboedo · 2023-06-21T13:45:54Z

hard for me to convey how much I love this ❤️

aboedo · 2023-06-21T13:46:36Z

aboedo · 2023-06-21T17:28:19Z

we can always iterate as we feel the need

vegaro · 2023-06-22T10:39:29Z

Not a blocker, but do you think there's a way we can remove the number of parameters of this function?

Well, thinking about it, we definitely should add a listener of some sort, instead of adding all those callbacks. Might do that in a different PR. That would join 4 parameters into 1. As for the others, I think they need to be there, but we can think of ways to refactor.

vegaro · 2023-06-22T10:51:12Z

We could add another one here that gets the active entitlements by doing active.keys

Well, I think that makes sense, but we are currently not displaying the active entitlements anywhere, only whether a user has any active entitlements or not.

We could add a place where it displays the active entitlements, and checks that it has the correct one instead, as we do in the current magic weather, this just seemed a simpler approach, but I'm ok changing it. Thoughts? @vegaro

Talked with @vegaro. Done in 5ab1901

vegaro · 2023-06-22T10:53:32Z

we can use the gradle library catalogs, but we can do it in another PR

Yeah I thought about that. Going to make that change in another PR, so we are using catalogs everywhere

Done in #1081

### Description This PR moves the new jetpack compose sample app added in #1056 to use gradle catalogs as added in #1059.

@tonidero

**This is an automatic release.** ### Bugfixes * Default customer info schema version to latest known by SDK (#1080) via Toni Rico (@tonidero) * Handle other diagnostics-related exceptions (#1076) via Toni Rico (@tonidero) * Return error in queryPurchases if error connecting to billing client (#1072) via Toni Rico (@tonidero) ### Other Changes * Fix offline entitlements integration tests (#1085) via Toni Rico (@tonidero) * Add defaultsRelease variant tests run configuration (#1074) via Toni Rico (@tonidero) * Compose sample app: move to gradle catalog (#1081) via Toni Rico (@tonidero) * Compose sample app: automate builds (#1082) via Toni Rico (@tonidero) * Compose sample app (#1056) via Toni Rico (@tonidero) * Migrate to Gradle version catalog (#1059) via Cesar de la Vega (@vegaro) * Trusted entitlements: Add logs with verification mode (#1067) via Toni Rico (@tonidero) * Sync pending purchases before getting customer info (#1073) via Toni Rico (@tonidero) * Refactor syncing pending transactions logic out of `Purchases` (#1058) via Toni Rico (@tonidero) * Refactor CustomerInfo listener and cache logic into CustomerInfoUpdater (#1052) via Toni Rico (@tonidero) * Trusted entitlements: Add integration tests (#1071) via Toni Rico (@tonidero) * Trusted entitlements: Add internal mechanism to force signing errors for tests (#1070) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>

tonidero added the test label Jun 7, 2023

tonidero commented Jun 7, 2023

View reviewed changes

tonidero commented Jun 8, 2023

View reviewed changes

tonidero marked this pull request as ready for review June 15, 2023 09:31

tonidero requested a review from a team June 15, 2023 09:31

aboedo approved these changes Jun 21, 2023

View reviewed changes

vegaro approved these changes Jun 22, 2023

View reviewed changes

tonidero added 11 commits June 22, 2023 13:32

Create project wizard

b943ed0

Basic navigation and screens

35ea771

Add basic paywall UI and RC integration

5930421

Add callbacks for different points of time

e7593aa

Improve weather screen

a383e62

Go back to main screen after successful purchase

7cf4f93

Small cleanup

39e55ff

Add user screen basic info and operations

0b8e53f

Extract SDK configuration to application

1ecfe02

Use metadata to customize paywall

9aca5f6

Fixes from review

8ceb316

tonidero force-pushed the compose-sample-app branch from 6a26294 to 8ceb316 Compare June 22, 2023 11:33

tonidero mentioned this pull request Jun 22, 2023

Compose sample app: move to gradle catalog #1081

Merged

Add extension to get active entitlements

5ab1901

tonidero enabled auto-merge (squash) June 22, 2023 12:07

tonidero merged commit 6b2581a into main Jun 22, 2023

tonidero deleted the compose-sample-app branch June 22, 2023 12:15

tonidero restored the compose-sample-app branch June 22, 2023 12:21

RCGitBot mentioned this pull request Jun 22, 2023

[AUTOMATIC] Release/6.5.1 #1084

Closed

tonidero deleted the compose-sample-app branch June 22, 2023 12:25

tonidero added a commit that referenced this pull request Jun 22, 2023

Compose sample app: move to gradle catalog (#1081)

6a48e92

### Description This PR moves the new jetpack compose sample app added in #1056 to use gradle catalogs as added in #1059.

RCGitBot mentioned this pull request Jun 23, 2023

[AUTOMATIC] Release/6.5.1 #1087

Merged

Uh oh!

Conversation

tonidero commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tonidero commented Jun 7, 2023 •

edited

Loading

codecov Bot commented Jun 7, 2023 •

edited

Loading