Skip to content

Improve offline entitlements logs to mention limitations of this mode#1039

Merged
tonidero merged 1 commit into
mainfrom
improve-offline-entitlement-logs
May 31, 2023
Merged

Improve offline entitlements logs to mention limitations of this mode#1039
tonidero merged 1 commit into
mainfrom
improve-offline-entitlement-logs

Conversation

@tonidero

Copy link
Copy Markdown
Contributor

Description

From our bug bash, we found that there are some situations that may be confusing to our users. This tries to improve the logs so some of the limitations of offline entitlements are clearer.

@tonidero tonidero requested a review from a team May 31, 2023 13:55
@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1039 (e3c2e88) into main (e5d9ac8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   85.54%   85.54%   -0.01%     
==========================================
  Files         175      175              
  Lines        6123     6122       -1     
  Branches      857      857              
==========================================
- Hits         5238     5237       -1     
  Misses        550      550              
  Partials      335      335              
Impacted Files Coverage Δ
...tlin/com/revenuecat/purchases/PostReceiptHelper.kt 94.18% <ø> (-0.07%) ⬇️
...at/purchases/strings/OfflineEntitlementsStrings.kt 0.00% <ø> (ø)
.../offlineentitlements/OfflineEntitlementsManager.kt 90.74% <100.00%> (ø)

@tonidero tonidero merged commit 96505f7 into main May 31, 2023
@tonidero tonidero deleted the improve-offline-entitlement-logs branch May 31, 2023 15:27
tonidero added a commit that referenced this pull request Jun 1, 2023
**This is an automatic release.**

### New Features
* Offline entitlements support (#1030) via Toni Rico (@tonidero)
### Bugfixes
* Fix billing connection error when querying purchases early in the
process lifetime (#1032) via Toni Rico (@tonidero)
### Performance Improvements
* Perform product entitlement mapping request after more critical
requests (#1017) via Toni Rico (@tonidero)
### Dependency Updates
* Bump fastlane from 2.212.2 to 2.213.0 (#1024) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Get offerings response from disk cache if available (#1029) via Toni
Rico (@tonidero)
* Improve offline entitlements logs to mention limitations of this mode
(#1039) via Toni Rico (@tonidero)
* Improve error message when backend returns internal error code (#1038)
via Toni Rico (@tonidero)
* PurchaseTester: Add new UI to configure internal proxy behavior
(#1016) via Toni Rico (@tonidero)
* Updated readme to include links to migration guides (#1021) via Marcos
Castany (@mcastany)
* Store offerings response in SharedPreferences (#1028) via Toni Rico
(@tonidero)
* Refactor offerings code out of Purchases (#1027) via Toni Rico
(@tonidero)

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants