Disable offline entitlements in observer mode#1014
Merged
tonidero merged 2 commits intoMay 23, 2023
Merged
Conversation
tonidero
commented
May 22, 2023
Contributor
Author
There was a problem hiding this comment.
We don't store observer mode directly, but we store the finishTransactions flag instead.
Contributor
There was a problem hiding this comment.
Maybe add a comment?
In iOS I solved this by changing the source of truth be called "observer mode", and derive finish transactions from that.
Contributor
Author
There was a problem hiding this comment.
Yeah... It's basically the same, but I guess we can have both, so it's easier to understand 👍
Codecov Report
@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
+ Coverage 85.37% 85.39% +0.02%
==========================================
Files 169 168 -1
Lines 6005 5993 -12
Branches 839 836 -3
==========================================
- Hits 5127 5118 -9
+ Misses 546 544 -2
+ Partials 332 331 -1
|
NachoSoto
approved these changes
May 22, 2023
ad811cd to
0d070e6
Compare
This was referenced May 24, 2023
tonidero
added a commit
that referenced
this pull request
May 25, 2023
**This is an automatic release.** ### New Features * Support DEFERRED mode (#985) via swehner (@swehner) * Add completion callback to syncPurchases API (#1002) via Toni Rico (@tonidero) ### Bugfixes * Workaround bug in android 4 for JSON objects with List<String> (#942) via Andy Boedo (@aboedo) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `fe45299` to `13773d2` (#1015) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Bump dokka to 1.8.10 to support Gradle 8 (#1009) via Toni Rico (@tonidero) * Disable offline entitlements temporarily (#1023) via Toni Rico (@tonidero) * Fix integration tests in CI (#1019) via Toni Rico (@tonidero) * Add offline entitlements integration tests (#1006) via Toni Rico (@tonidero) * Disable offline entitlements in observer mode (#1014) via Toni Rico (@tonidero) * Extracts setup and teardown to BasePurchasesTest (#1011) via Cesar de la Vega (@vegaro) * Support forcing server errors for tests (#1008) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SDK-3139
This PR will disable offline entitlements entirely in observer mode. We won't update the product-entitlement cache either. This feature doesn't provide any value for users in observer mode so can disable it for them without consequences.