Skip to content

Add PR template#54

Merged
kpamnany merged 1 commit intov1.9.2+RAIfrom
kp-add-pr-template
Sep 19, 2023
Merged

Add PR template#54
kpamnany merged 1 commit intov1.9.2+RAIfrom
kp-add-pr-template

Conversation

@kpamnany
Copy link
Copy Markdown

@kpamnany kpamnany commented Sep 18, 2023

@kpamnany kpamnany requested a review from NHDaly September 18, 2023 17:22
NHDaly
NHDaly approved these changes Sep 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel that this covers everything discussed in the ticket.

In particular, we want people to at least open a github issue in the julia upstream to discuss problems and ideas if they aren't ready to open a public julia PR, and that's not captured here?

But as a first pass this seems reasonable

@kpamnany kpamnany merged commit fe86606 into v1.9.2+RAI Sep 19, 2023
@kpamnany kpamnany deleted the kp-add-pr-template branch September 19, 2023 15:18
@nickrobinson251
Copy link
Copy Markdown
Member

nickrobinson251 commented Sep 19, 2023

Does this actually add a template? How do i use it? I tried making a PR (e.g. from v1.9.2+RAI...RelationalAI:julia:v1.9.3+RAI) and i was expecting the PR description box to be populated with this template, but it wasn't... Does this template PR need to be to the default branch (master)? https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates#pull-request-templates

Screenshot 2023-09-19 at 17 56 47

@d-netto
Copy link
Copy Markdown

d-netto commented Sep 19, 2023

Apparently this PR doesn't work on nix-shell. On fe86606 I get:

make: *** [Makefile:62: julia-deps] Error 2
error: builder for '/nix/store/1g42i0djvdb9pdibv5la5nfvhq945n43-julia-1.9.2.drv' failed with exit code 2

While it works just fine on a202a8e.

kpamnany added a commit that referenced this pull request Sep 20, 2023
@kpamnany
Revert "Add PR template (#54)"
dac7525 
This reverts commit fe86606.
@kpamnany kpamnany mentioned this pull request Sep 20, 2023
Merged
kpamnany added a commit that referenced this pull request Sep 20, 2023
@kpamnany
Revert "Add PR template (#54)" (#61)
1e89d25 
This reverts commit fe86606.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NHDaly NHDaly NHDaly approved these changes

@nickrobinson251 nickrobinson251 Awaiting requested review from nickrobinson251

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kpamnany @nickrobinson251 @d-netto @NHDaly