cblas: mark cblas_xerbla and F77_xerbla symbols as weak#521
Merged
langou merged 2 commits intoReference-LAPACK:masterfrom Mar 18, 2021
veprbl:pr/cblas_use_weak_symbols
Merged
cblas: mark cblas_xerbla and F77_xerbla symbols as weak#521langou merged 2 commits intoReference-LAPACK:masterfrom veprbl:pr/cblas_use_weak_symbols
langou merged 2 commits intoReference-LAPACK:masterfrom
veprbl:pr/cblas_use_weak_symbols
Conversation
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 1820 1820
Lines 170893 170893
=======================================
Hits 142411 142411
Misses 28482 28482 Continue to review full report at Codecov.
|
Collaborator
|
Hi! Thanks for working on that! Please see my comment here: #440 (comment) |
weslleyspereira
approved these changes
Mar 18, 2021
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
…_symbols cblas: mark cblas_xerbla and F77_xerbla symbols as weak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix an issue reported by @bobrik in #440 (comment), although I discovered it was also appearing on x86_64-darwin. Thanks to @langou for the useful summary #440 (comment) .