MOD-10714 Integrate Rust RSSortingVector#6887
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Performance Regressions and Issues - Comparison between master and jonas-swap-rssorting-vector.Time Period from 30 days ago. (environment used: oss-standalone)
Tests with No Significant Changes (31 tests)Tests with No Significant Changes
|
4cd92f9 to
0f235c9
Compare
0f235c9 to
93d32bd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6887 +/- ##
==========================================
+ Coverage 83.83% 83.85% +0.01%
==========================================
Files 365 364 -1
Lines 55165 55106 -59
Branches 14294 14267 -27
==========================================
- Hits 46249 46209 -40
+ Misses 8758 8739 -19
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f3f067f to
727466a
Compare
8429b4c to
2cc0fb3
Compare
3dcd2ab to
955eb09
Compare
ee5a6ce to
004d154
Compare
oss-standalone-2025-11-10-13-45-00-None-search-numeric-optimize.json
Outdated
Show resolved
Hide resolved
* RSSortingVector FFI cleanup * fix: remove UTF-8 assumption from RSValueFFI * MOD-10714 Integrate Rust RSSortingVector * fix workspace hack crate * fix lint
1a062d6 to
58c236a
Compare
58c236a to
6e54e8a
Compare
6e54e8a to
84a513b
Compare
84a513b to
5d479ff
Compare
This benchmark seems to be affected by the same error as #8005.
5d479ff to
215ca60
Compare
* skip `benchmark-search-oss-cluster-04-primaries-threads-6` This benchmark seems to be affected by the same error as #8005. * RSSortingVector FFI cleanup * fix: remove UTF-8 assumption from RSValueFFI * MOD-10714 Integrate Rust RSSortingVector * fix workspace hack crate * fix lint
* skip `benchmark-search-oss-cluster-04-primaries-threads-6` This benchmark seems to be affected by the same error as #8005. * RSSortingVector FFI cleanup * fix: remove UTF-8 assumption from RSValueFFI * MOD-10714 Integrate Rust RSSortingVector * fix workspace hack crate * fix lint
Recreate #6855 bc of branch name issue
Mark if applicable
Note
Migrates sortable field storage to a Rust implementation with C FFI and updates callers accordingly.
sortable.c/hvector logic with Rustsorting_vectorcrate exposed throughsorting_vector_ffi; addsorting_vector_rs.hdocument.c,doc_table.c,debug_commands.c) to useRSSortingVector_*API (New/Free/PutNum/PutStr/PutStrNormalize/Get/Length/GetMemorySize) and remove legacyNewSortingVector/SortingVector_FreePutStrNormalize) instead of pre-normalizing in Cvalueto work with byte strings (create_string(Vec<u8>),as_str_bytes) and addRSValue_NewCopiedStringusage in FFIsorting_vector,sorting_vector_ffi) and wire throughredisearch_rsentrypoint; adjust dependencies (dropthiserrorfromsorting_vector, addredis-moduletovaluefor MUSL)Written by Cursor Bugbot for commit 215ca60. This will update automatically on new commits. Configure here.