[MOD-10920] Improve BUILD_INTEL_SVS_OPT flag validation#6865
Merged
[MOD-10920] Improve BUILD_INTEL_SVS_OPT flag validation#6865
Conversation
GuyAv46
approved these changes
Sep 21, 2025
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Sep 21, 2025
Fix build script logic for Intel SVS option handling (cherry picked from commit 95695cc)
Contributor
|
Successfully created backport PR for |
nafraf
pushed a commit
that referenced
this pull request
Sep 22, 2025
Fix build script logic for Intel SVS option handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with Redis conventions (yes/no options) while maintaining RediSearch conventions (1/0 flags) for compatibility with both Redis builds and internal usage.
Current:
BUILD_INTEL_SVS_OPTenables Intel SVS optimization for any non-zero valueChange: Only accept explicit values
"yes"or"1"to enable the feature