Conversation
rename SVS_PRE_COMPILED_LIB to BUILD_INTEL_SVS_OPT
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6843 +/- ##
==========================================
- Coverage 86.98% 86.93% -0.06%
==========================================
Files 288 288
Lines 46168 46173 +5
Branches 9072 9072
==========================================
- Hits 40159 40139 -20
- Misses 5858 5883 +25
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Sep 16, 2025
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
…nd rename SVS environment variable (#6845) [MOD-11477] [MOD-10920] Fix vector compression type reporting and rename SVS environment variable (#6843) fix bug in info rename SVS_PRE_COMPILED_LIB to BUILD_INTEL_SVS_OPT (cherry picked from commit a78a74d) Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
lerman25
pushed a commit
that referenced
this pull request
Sep 24, 2025
…ame SVS environment variable (#6843) fix bug in info rename SVS_PRE_COMPILED_LIB to BUILD_INTEL_SVS_OPT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOD-11477 Bug Fix: Incorrect compression type in
FT.INFOProblem:
The
FT.INFOcommand was incorrectly reporting SVS index compression types when Intel SVS optimizations are enaled. TheisLVQSupported()function always returnedfalsebecause theSVS_PRE_COMPILED_LIBmacro was never defined during compilation, even when the environment variable was set.Root Cause:
The environment variable
SVS_PRE_COMPILED_LIBwas not being translated into a compilation macro. The conditional compilation check insrc/vector_index.c:was always evaluating to
falsebecauseSVS_PRE_COMPILED_LIBwas undefined at compile time.Fix:
FT.INFOnow accurately reports compression types when using precompiled Intel SVS librariesMOD-10920 Environment Variable Rename
Change:
Renamed
SVS_PRE_COMPILED_LIBtoBUILD_INTEL_SVS_OPTthroughout the codebase to align with naming conventions requested in MOD-10920.Files Modified:
build.sh: Updated environment variable name and default valueCMakeLists.txt: Updated CMake condition and macro definitionsrc/vector_index.c: Updated conditional compilation directive