[MOD-10622] Optimize rs_wall_clock_diff_ns by removing redundant if branch#6660
Merged
[MOD-10622] Optimize rs_wall_clock_diff_ns by removing redundant if branch#6660
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit d35f404 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #6660 +/- ##
==========================================
- Coverage 87.55% 87.52% -0.03%
==========================================
Files 282 282
Lines 44792 44789 -3
Branches 7712 7712
==========================================
- Hits 39216 39201 -15
- Misses 5456 5468 +12
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…in rs_wall_clock_diff_ns
GuyAv46
approved these changes
Aug 17, 2025
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 17, 2025
…t if branch (#6663) [MOD-10622] Optimize rs_wall_clock_diff_ns by removing redundant if branch (#6660) * Optimize diff_ns by removing redundant if * change type * Fix nanosecond constant type and improve time difference calculation in rs_wall_clock_diff_ns (cherry picked from commit dfc2deb) Co-authored-by: lerman25 <58445352+lerman25@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 17, 2025
…nt if branch (#6664) [MOD-10622] Optimize rs_wall_clock_diff_ns by removing redundant if branch (#6660) * Optimize diff_ns by removing redundant if * change type * Fix nanosecond constant type and improve time difference calculation in rs_wall_clock_diff_ns (cherry picked from commit dfc2deb) Co-authored-by: lerman25 <58445352+lerman25@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 17, 2025
…t if branch (#6665) [MOD-10622] Optimize rs_wall_clock_diff_ns by removing redundant if branch (#6660) * Optimize diff_ns by removing redundant if * change type * Fix nanosecond constant type and improve time difference calculation in rs_wall_clock_diff_ns (cherry picked from commit dfc2deb) Co-authored-by: lerman25 <58445352+lerman25@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the
rs_wall_clock_diff_nsfunction insrc/rs_wall_clock.hby removing the logic that adjusted for negative nanosecond differences.