Skip to content

Trie: hide expensive memory usage computation behind a test-specific feature flag.#6642

Merged
LukeMathWalker merged 1 commit intomasterfrom
gate-test-utils
Aug 13, 2025
Merged

Trie: hide expensive memory usage computation behind a test-specific feature flag.#6642
LukeMathWalker merged 1 commit intomasterfrom
gate-test-utils

Conversation

@LukeMathWalker
Copy link
Copy Markdown
Collaborator

We can't use #[cfg(test)] because we need the recursive_mem_usage method to be visible for tests in the tests folder.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.45%. Comparing base (870e099) to head (1b7dabe).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6642      +/-   ##
==========================================
- Coverage   87.45%   87.45%   -0.01%     
==========================================
  Files         282      282              
  Lines       44844    44844              
  Branches     7747     7747              
==========================================
- Hits        39219    39217       -2     
- Misses       5507     5509       +2     
  Partials      118      118              
Flag Coverage Δ
flow 84.49% <ø> (-0.12%) ⬇️
unit 49.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LukeMathWalker LukeMathWalker added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit 9e7650f Aug 13, 2025
20 checks passed
@LukeMathWalker LukeMathWalker deleted the gate-test-utils branch August 13, 2025 12:34
redisearch-backport-pull-request bot pushed a commit that referenced this pull request Aug 13, 2025
@redisearch-backport-pull-request
Copy link
Copy Markdown
Contributor

github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2025
…cific feature flag. (#6645)

Trie: hide expensive memory usage computation behind a test-specific feature flag. (#6642)

(cherry picked from commit 9e7650f)

Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>
@LukeMathWalker LukeMathWalker restored the gate-test-utils branch February 6, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants