Update vectors memory in total index info memory [MOD-10841]#6613
Merged
Update vectors memory in total index info memory [MOD-10841]#6613
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6613 +/- ##
==========================================
- Coverage 87.47% 87.42% -0.06%
==========================================
Files 282 282
Lines 44842 44844 +2
Branches 7747 7747
==========================================
- Hits 39226 39205 -21
- Misses 5498 5521 +23
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meiravgri
reviewed
Aug 8, 2025
meiravgri
approved these changes
Aug 12, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6613-to-2.8 origin/2.8
cd .worktree/backport-6613-to-2.8
git switch --create backport-6613-to-2.8
git cherry-pick -x c987ba93f96a8a5e67804ed56434c536eb7d5ba8 ae2d02520414f6447b60fdcf4394a51620c4fb2a c4e3f3822e871ba07ab54545d3605c7a9622689a b45b0cf6f427897dd4d820a47c6b4514691bfe28 e87e6e7b5d5d25a377a34370c0161e977fc204e0 05d991556335b15e17283e341838d601bb082e76 edddaab546183f59e7fa28d97af90b94746c6ea7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-6613-to-2.6 origin/2.6
cd .worktree/backport-6613-to-2.6
git switch --create backport-6613-to-2.6
git cherry-pick -x c987ba93f96a8a5e67804ed56434c536eb7d5ba8 ae2d02520414f6447b60fdcf4394a51620c4fb2a c4e3f3822e871ba07ab54545d3605c7a9622689a b45b0cf6f427897dd4d820a47c6b4514691bfe28 e87e6e7b5d5d25a377a34370c0161e977fc204e0 05d991556335b15e17283e341838d601bb082e76 edddaab546183f59e7fa28d97af90b94746c6ea7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-6613-to-2.10 origin/2.10
cd .worktree/backport-6613-to-2.10
git switch --create backport-6613-to-2.10
git cherry-pick -x c987ba93f96a8a5e67804ed56434c536eb7d5ba8 ae2d02520414f6447b60fdcf4394a51620c4fb2a c4e3f3822e871ba07ab54545d3605c7a9622689a b45b0cf6f427897dd4d820a47c6b4514691bfe28 e87e6e7b5d5d25a377a34370c0161e977fc204e0 05d991556335b15e17283e341838d601bb082e76 edddaab546183f59e7fa28d97af90b94746c6ea7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-6613-to-8.2 origin/8.2
cd .worktree/backport-6613-to-8.2
git switch --create backport-6613-to-8.2
git cherry-pick -x c987ba93f96a8a5e67804ed56434c536eb7d5ba8 ae2d02520414f6447b60fdcf4394a51620c4fb2a c4e3f3822e871ba07ab54545d3605c7a9622689a b45b0cf6f427897dd4d820a47c6b4514691bfe28 e87e6e7b5d5d25a377a34370c0161e977fc204e0 05d991556335b15e17283e341838d601bb082e76 edddaab546183f59e7fa28d97af90b94746c6ea7 |
alonre24
added a commit
that referenced
this pull request
Aug 13, 2025
* account for vector index in total memory info * Add svs-vamana to info telemetry * revert vamana (split to other PR) * revert manually * move vector overhead to index memory usage function (WIP) * remove leftover * fix vector overhead usage (cherry picked from commit 870e099)
This was referenced Aug 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
…6641) Update vectors memory in total index info memory (#6613) * account for vector index in total memory info * Add svs-vamana to info telemetry * revert vamana (split to other PR) * revert manually * move vector overhead to index memory usage function (WIP) * remove leftover * fix vector overhead usage (cherry picked from commit 870e099)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
As this field is a "best-effort" and non-accurate, we aim to keep it as accurate as possible and add the vector index info, which can a large portion of the total index memory to it.
Mark if applicable