Fix FieldSpec Cleanup on failed RDB load - [MOD-10307]#6410
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6410 +/- ##
==========================================
+ Coverage 89.26% 89.29% +0.03%
==========================================
Files 251 251
Lines 41330 41308 -22
Branches 3623 3623
==========================================
- Hits 36895 36888 -7
+ Misses 4391 4376 -15
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Jul 1, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6410-to-2.8 origin/2.8
cd .worktree/backport-6410-to-2.8
git switch --create backport-6410-to-2.8
git cherry-pick -x fef0d10c514a0a9272c0725c0ff421774fa3a1a4 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-6410-to-2.6 origin/2.6
cd .worktree/backport-6410-to-2.6
git switch --create backport-6410-to-2.6
git cherry-pick -x fef0d10c514a0a9272c0725c0ff421774fa3a1a4 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-6410-to-2.10 origin/2.10
cd .worktree/backport-6410-to-2.10
git switch --create backport-6410-to-2.10
git cherry-pick -x fef0d10c514a0a9272c0725c0ff421774fa3a1a4 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* fix field loading * enable test * improve comment * fix additional leak (cherry picked from commit fef0d10)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* fix field loading * enable test * improve comment * fix additional leak (cherry picked from commit fef0d10)
Contributor
|
Successfully created backport PR for |
GuyAv46
added a commit
that referenced
this pull request
Jul 2, 2025
* fix field loading * enable test * improve comment * fix additional leak (cherry picked from commit fef0d10)
GuyAv46
added a commit
that referenced
this pull request
Jul 2, 2025
* fix field loading * enable test * improve comment * fix additional leak (cherry picked from commit fef0d10)
GuyAv46
added a commit
that referenced
this pull request
Jul 2, 2025
* fix field loading * enable test * improve comment * fix additional leak (cherry picked from commit fef0d10)
This was referenced Jul 2, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 7, 2025
* Fix FieldSpec Cleanup on failed RDB load - [MOD-10307] (#6410) * fix field loading * enable test * improve comment * fix additional leak (cherry picked from commit fef0d10) * enable short read tests on sanitizer (cherry picked from commit 83bec43) * minor tool improvements (cherry picked from commit 0294d6f)
JoanFM
pushed a commit
that referenced
this pull request
Apr 13, 2026
* fix field loading * enable test * improve comment * fix additional leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix an issue when loading a schema from RDB, and we decide to abort for some reason.
We need to make sure the number of
IndexError_Initcalls matches the number ofIndexError_Clearcalls we later do, otherwise we may free the global "N/A" string.Mark if applicable