Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6364 +/- ##
==========================================
- Coverage 88.98% 88.92% -0.07%
==========================================
Files 250 250
Lines 41415 41409 -6
Branches 3556 3556
==========================================
- Hits 36854 36823 -31
- Misses 4512 4537 +25
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kei-nan
approved these changes
Jun 24, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-6364-to-8.0 origin/8.0
cd .worktree/backport-6364-to-8.0
git switch --create backport-6364-to-8.0
git cherry-pick -x 5da87174a9eb6847485c375d973c3cb31e0befd9 |
GuyAv46
added a commit
that referenced
this pull request
Jun 24, 2025
* fix TTL dictionary * add a failing test * delete dummy test (cherry picked from commit 5da8717)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
true(1) on equality, andfalse(0) otherwiseNote
The bug can occur if a low ID is mapped to the same bucket as a high ID that is in the dictionary. Looking for the low ID may return the high ID as a match
Mark if applicable