Skip to content

Improve release-drafter#38

Merged
PuneetGopinath merged 2 commits intomainfrom
feature/improve-release-drafter
May 16, 2021
Merged

Improve release-drafter#38
PuneetGopinath merged 2 commits intomainfrom
feature/improve-release-drafter

Conversation

@Andre601
Copy link
Member

Thank you for contributing! Please check the following things before submiting your PR:

Required:

If necessary:

  • I have updated the README and documentation.
  • I have updated the ChangeLog with the changes I have made.

Improves the displayed title for the categories, changing them to ### $TITLE

Example:

Closes #


Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

@Andre601 Andre601 added the Status: Ready The Pull request is ready for reviews and getting merged label May 16, 2021
Copy link
Member

@abhijoshi2k abhijoshi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Andre601
Copy link
Member Author

While we're at it, would I like to ask, if we perhaps should ignore PRs targeting GitHub Action workflows, since people don't really need this info on changelog, right?

@abhijoshi2k
Copy link
Member

While we're at it, would I like to ask, if we perhaps should ignore PRs targeting GitHub Action workflows, since people don't really need this info on changelog, right?

I too really doubt if people read it. We should focus more on workflow functionality is my opinion.

@Andre601
Copy link
Member Author

I changed it, so that PRs targeting github action workflows are ignored.

@PuneetGopinath PuneetGopinath merged commit 642150d into main May 16, 2021
@PuneetGopinath PuneetGopinath deleted the feature/improve-release-drafter branch May 16, 2021 10:05
@Andre601
Copy link
Member Author

Now we have to wait for GitHub Actions to be fixed for this to update the release xD

@PuneetGopinath
Copy link
Member

Now we have to wait for GitHub Actions to be fixed for this to update the release xD

What to be fixed

@Andre601
Copy link
Member Author

@Andre601
Copy link
Member Author

Means currently GitHub actions is not be available.

Yes. Currently scheduled actions are in "in queue" mode indefinitely (perhaps even time out after a long time?) until GitHub fixed the issue.

You can see this happening in the Actions tab of this repo:
image

@PuneetGopinath
Copy link
Member

PuneetGopinath commented May 16, 2021

Yes, do you know what problem

@Andre601
Copy link
Member Author

Nah. We just have to wait for GitHub to fix this.

@PuneetGopinath
Copy link
Member

You are too fast, I think as soon as you saw in Actions tab, I think you rushed to GitHub status, right?

@Andre601
Copy link
Member Author

I already knew this for some time now when I was working on one of my projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Ready The Pull request is ready for reviews and getting merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants