Merged
Conversation
Andre601
requested changes
May 15, 2021
Co-authored-by: Andre_601 <11576465+Andre601@users.noreply.github.com>
abhijoshi2k
requested changes
May 15, 2021
Andre601
requested changes
May 15, 2021
Andre601
reviewed
May 15, 2021
Andre601
reviewed
May 15, 2021
Co-authored-by: Andre_601 <11576465+Andre601@users.noreply.github.com>
Andre601
requested changes
May 15, 2021
Member
Andre601
left a comment
There was a problem hiding this comment.
Almost good. Just needs some changes in some wording imo.
Co-authored-by: Andre_601 <11576465+Andre601@users.noreply.github.com>
Andre601
approved these changes
May 15, 2021
abhijoshi2k
approved these changes
May 15, 2021
Member
Author
|
I just thought, I will squash and merge when you approve this pr, but anyway why do you not use squash and merge |
Member
|
I thought you were only waiting for my review as I was late at giving review. So I made sure it gets merged immediately |
Member
Author
Squash and merge will make one commit, and that's the best I consider when there are more than 10 commits in pr. |
Member
|
I'll keep that in mind. |
Member
Author
|
Ok, good night |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing! Please check the following things before submiting your PR:
Required:
If necessary:
Closes #
Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.