fix(docs): fix missing overloads in docs when overload count is less than 3#7367
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Oct 29, 2023
Merged
fix(docs): fix missing overloads in docs when overload count is less than 3#7367benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
benlesh
approved these changes
Oct 29, 2023
Member
|
This may require a separate PR for 7.x (The current website) cc @jakovljevic-mladen |
Member
|
Thank you, @tmair |
Member
tmair
added a commit
to tmair/rxjs
that referenced
this pull request
Oct 30, 2023
Contributor
Author
Here is the PR for the @jakovljevic-mladen I think that also the associated issue can be closed after the fix has landed on the |
Member
|
Thanks @tmair. If you want to automatically close related issue, you can just write somewhere in the PR description |
benlesh
pushed a commit
that referenced
this pull request
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue in the docs app, that does not display the overlays if the number of overloads is 2. The overload is printed at the top of the document.
Related issue (if exists): #5281
See also AIO Commit: angular/angular@e0c7360