fix(windowWhen): don't signal on complete#7052
Closed
jakovljevic-mladen wants to merge 6 commits intoReactiveX:8.xfrom
Closed
fix(windowWhen): don't signal on complete#7052jakovljevic-mladen wants to merge 6 commits intoReactiveX:8.xfrom
jakovljevic-mladen wants to merge 6 commits intoReactiveX:8.xfrom
Conversation
5 tasks
Member
|
Haven't reviewed yet, but I know the bug. It IS a bug, but the fix is also a breaking change. So we need to punt until next major. |
Member
Author
|
Switching to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR is split to two commits:
windowWhenwithbufferWhen- it fixes a now considered bug, so that it stops acceptingcompletenotifications from Observable emitted byclosingSelector;Related issue (if exists):
Closes #6876
Closes #6627