docs: Inline templates, correct type errors that revealed.#6936
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Jul 20, 2022
Merged
docs: Inline templates, correct type errors that revealed.#6936benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
jakovljevic-mladen
approved these changes
Apr 19, 2022
Member
jakovljevic-mladen
left a comment
There was a problem hiding this comment.
LGTM. One check can be removed since it was moved to another place.
| [path]="tab.path" | ||
| [region]="tab.region" | ||
| [header]="tab.header" | ||
| > |
| @@ -45,14 +71,16 @@ export class SearchResultsComponent implements OnChanges { | |||
| } | |||
Member
There was a problem hiding this comment.
Since you added check in ngOnChanges, this part: if (!search) { return []; } can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simply uses inline template instead of
templateUrl. I've always hatedtemplateUrlhaha.Anyhow, doing this reveals more type errors and gives better feedback in VS Code (if you're using Angular Language Service).