Skip to content

chore: include docs build scripts in pipeline + fix scripts#6913

Merged
jakovljevic-mladen merged 1 commit intoReactiveX:masterfrom
jakovljevic-mladen:include_running_docs_build_scripts_in_gh_pipelines
Mar 9, 2023
Merged

chore: include docs build scripts in pipeline + fix scripts#6913
jakovljevic-mladen merged 1 commit intoReactiveX:masterfrom
jakovljevic-mladen:include_running_docs_build_scripts_in_gh_pipelines

Conversation

@jakovljevic-mladen
Copy link
Member

Description:
To avoid issues that we had multiple times so far where the docs build was broken after some PR merges, I'm adding running docs build and generation scripts to the pipelines. This only runs setup and build scripts from the docs_app, it does not deploy app remotely.

Related issue (if exists):
None, but one of the latest issue we had was fixed in #6881. We want to avoid having such PRs by including these runs. Also, running current build script will fail pipelines until #6912 is merged.

@benlesh
Copy link
Member

benlesh commented Apr 19, 2022

Let me know if you need anything for this.

@jakovljevic-mladen jakovljevic-mladen force-pushed the include_running_docs_build_scripts_in_gh_pipelines branch from 9177c2e to db8b22b Compare April 19, 2022 06:45
@jakovljevic-mladen
Copy link
Member Author

Changes from the commit 1685d86 were suggested by this comment.

@jakovljevic-mladen
Copy link
Member Author

Let me know if you need anything for this.

Thanks @benlesh, I somehow managed to fix everything. This PR is ready for review. @kwonoj, can you please review this PR as well?

@jakovljevic-mladen jakovljevic-mladen changed the title chore: include docs build scripts in pipeline chore: include docs build scripts in pipeline + fix scripts Apr 19, 2022
@jakovljevic-mladen jakovljevic-mladen force-pushed the include_running_docs_build_scripts_in_gh_pipelines branch from c87a0db to f271f13 Compare December 15, 2022 08:24
@jakovljevic-mladen jakovljevic-mladen force-pushed the include_running_docs_build_scripts_in_gh_pipelines branch from eb081d8 to c79e8b5 Compare December 27, 2022 08:29
@benlesh
Copy link
Member

benlesh commented Mar 7, 2023

@jakovljevic-mladen feel free to merge these into 7.x and master as you please.

@benlesh benlesh added 7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x labels Mar 7, 2023
@jakovljevic-mladen jakovljevic-mladen merged commit afb1c66 into ReactiveX:master Mar 9, 2023
@jakovljevic-mladen jakovljevic-mladen deleted the include_running_docs_build_scripts_in_gh_pipelines branch March 9, 2023 08:09
jakovljevic-mladen added a commit that referenced this pull request Mar 9, 2023
@jakovljevic-mladen
Copy link
Member Author

Cherry-picked to 7.x.

One note: changes from this PR only will now include running setup and build scripts from the docs_app. The result of this action will not be used to automatically deploy the docs app to our official docs site. This will be useful to avoid having a follow-up PR that fix docs-app related issues that could have been avoided if this step was included in the original PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants