fix: clear subscription on shareReplay completion#5044
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Nov 26, 2019
Merged
fix: clear subscription on shareReplay completion#5044benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
|
Looks good, thanks for the help. |
The subscription needs to be cleared to prevent the implementation holding a reference to the completed source. In Angular, not clearing the reference can lead to components not being garbage collected. Closes ReactiveX#5034
benlesh
approved these changes
Nov 21, 2019
benlesh
requested changes
Nov 21, 2019
Member
benlesh
left a comment
There was a problem hiding this comment.
Can we have a test that verifies this is working?
benlesh
approved these changes
Nov 26, 2019
benlesh
pushed a commit
that referenced
this pull request
Nov 26, 2019
The subscription needs to be cleared to prevent the implementation holding a reference to the completed source. In Angular, not clearing the reference can lead to components not being garbage collected. Closes #5034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In
shareReplay, the subscription needs to be cleared to prevent the implementation holding a reference to the completed source. In Angular, not clearing the reference can lead to components not being garbage collected.Using the DevTools, I've verified that the fix in this PR is required, but I have no idea how a test could be written for this sort of thing.
Related issue (if exists): #5034