Skip to content

feat(delayWhen): add index to the selector function#2473

Merged
benlesh merged 1 commit intoReactiveX:masterfrom
kwonoj:pr-2409
Jul 26, 2018
Merged

feat(delayWhen): add index to the selector function#2473
benlesh merged 1 commit intoReactiveX:masterfrom
kwonoj:pr-2409

Conversation

@kwonoj
Copy link
Copy Markdown
Member

@kwonoj kwonoj commented Mar 16, 2017

#2388

This is for re-merge #2409, all credit goes to @martinsik .

Description:

Related issue (if exists):

@kwonoj kwonoj requested a review from benlesh March 16, 2017 21:47
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0007%) to 97.69% when pulling 688ea18 on kwonoj:pr-2409 into e2696db on ReactiveX:master.

@benlesh
Copy link
Copy Markdown
Member

benlesh commented Mar 30, 2018

Ugh. @kwonoj, can we get this updated? Perhaps a new PR if necessary?

@benlesh
Copy link
Copy Markdown
Member

benlesh commented May 4, 2018

This needs refactored add added to v6 :\ . Ugh, the backlog... haha.. sorry @kwonoj

@martinsik
Copy link
Copy Markdown
Contributor

@benlesh I made the original commit so I can have a look at it.

@cartant
Copy link
Copy Markdown
Collaborator

cartant commented Jun 3, 2018

@benlesh This has been rebased and should be ready for review/merge.

@benlesh benlesh merged commit 0979d31 into ReactiveX:master Jul 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2018
@kwonoj kwonoj deleted the pr-2409 branch October 4, 2019 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants