feat(delayWhen): add index to the selector function#2409
feat(delayWhen): add index to the selector function#2409kwonoj merged 1 commit intoReactiveX:masterfrom
Conversation
|
Change looks fine, but I assume TypeScript users who used selector before encounter compilation error by selector signature changes? |
|
@kwonoj I don't think so... since arguments are optional in JavaScript, TypeScript shouldn't complain I don't think. |
|
@kwonoj confirmed... |
|
Thanks for confirmation. I'll check this in around today to tomorrow. |
|
Oops.... @kwonoj, we didn't want to merge this new feature until after we patched the existing minor. |
|
@benlesh 😱 should this be reverted? |
|
@kwonoj yes, please. What I'd like to do is merge all of the |
|
ugh.. so we're going to have to re-merge this later. :) @kwonoj can you open another PR with these changes? (no worries @martinsik, your github credit is already in the history :) ) |
|
Yup, will do. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds current index to the selector function in
delayWhenoperator.Related issue (if exists):
#2388