perf(patcher): Silence trace logs to fix GC thrashing and OOM#3287
Merged
Conversation
Member
Author
|
Example below: 
|
oSumAtrIX
reviewed
Apr 7, 2026
Member
|
feature wise lgtm "Minimum patcher log level" could be renamed to "Minimum log level" since its in patcher group already |
oSumAtrIX
approved these changes
Apr 12, 2026
Member
|
Need @Axelen123 approval too |
Axelen123
requested changes
Apr 13, 2026
Throw instead of waiting indefinitely when no downloaders are loaded
Axelen123
requested changes
Apr 14, 2026
Axelen123
approved these changes
Apr 22, 2026
Axelen123
left a comment
Member
There was a problem hiding this comment.
Looks good to me. You can squash after cleaning up the imports in AdvancedSettingsViewModel.kt.
Sorry for taking a while to review.
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 22, 2026
# app [2.6.0-dev.12](v2.6.0-dev.11...v2.6.0-dev.12) (2026-04-22) ### Performance Improvements * **patcher:** Silence trace logs to fix GC thrashing and OOM ([#3287](#3287)) ([ab4bdd3](ab4bdd3))
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 26, 2026
# app [2.6.0](v2.5.1...v2.6.0) (2026-04-26) ### Bug Fixes * Adjust font size and fix letter spacing in announcements ([e1660a7](e1660a7)) * BusError when running 32b binary on armv8 with compatibility ([#3279](#3279)) ([c1e1a82](c1e1a82)) * Dashboard padding ([5f757b6](5f757b6)) * Don't hide PatchOptions behind keyboard ([dd3d474](dd3d474)) * handle errors while loading sources ([b64dae2](b64dae2)) * Ignore RichTap vibrator hardware crash ([7856652](7856652)) * Missing database migration file [no ci] ([df9b44c](df9b44c)) * Paddings for AppScreen and PatchesScreen ([af3d0d7](af3d0d7)) * Preserve applied patches on patched apps when source patches is deleted ([#3227](#3227)) ([4884fdb](4884fdb)) * **Updater:** Handle session death ([#3249](#3249)) ([f1c56aa](f1c56aa)) * UpdateScreen padding ([e3c6d57](e3c6d57)) ### Features * Better styling for announcements ([4f88357](4f88357)) * enable Ackpine logging ([7cf28c0](7cf28c0)) * Improve AppsScreen design, add app pinning and jump to top ([#3240](#3240)) ([46720a4](46720a4)) * Improve patch options ([#3213](#3213)) ([90667c8](90667c8)) ### Performance Improvements * **patcher:** Silence trace logs to fix GC thrashing and OOM ([#3287](#3287)) ([ab4bdd3](ab4bdd3))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patcher generates millions of very detailed trace logs.
Previously, the manager was trying to process every single one of these, even though they weren't being shown to you. This created an flood of IPC packets and "GC Thrashing" (forcing the system to constantly clear out massive amounts of memory).
Thus making patching extra slow on low-end devices.
Silencing these logs makes patching significantly faster and can prevents an
OutOfMemoryErrorexception.Advanced=>Patcher=>Minimum patcher log level