Skip to content

protect the temporary SEXPs produced by wrap#784

Merged
eddelbuettel merged 3 commits intomasterfrom
bugfix/proxy-sexp-protection
Dec 6, 2017
Merged

protect the temporary SEXPs produced by wrap#784
eddelbuettel merged 3 commits intomasterfrom
bugfix/proxy-sexp-protection

Conversation

@kevinushey
Copy link
Contributor

Should resolve #780.

@kevinushey kevinushey force-pushed the bugfix/proxy-sexp-protection branch from b1c0481 to 69d2c94 Compare December 4, 2017 21:34
@eddelbuettel
Copy link
Member

Thanks Kevin -- looks very good, will probably merge tomorrow!

@kevinushey kevinushey force-pushed the bugfix/proxy-sexp-protection branch from 79a6cd5 to 049ecfd Compare December 4, 2017 22:04
@kevinushey
Copy link
Contributor Author

I went through and cleaned up a number of other usages of wrap() -- some of these changes err on the side of caution, but I think it's worth it since the stack-based protection mechanism is quite cheap.

@eddelbuettel
Copy link
Member

@kevinushey I presume you saw but something in the last one upset the unit tests.

@eddelbuettel
Copy link
Member

FYI, full rev dep running, 100 packages in and picture perfect. Will probably merge by tomorrow.

@eddelbuettel eddelbuettel merged commit c3b26f6 into master Dec 6, 2017
@eddelbuettel eddelbuettel deleted the bugfix/proxy-sexp-protection branch December 21, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange behavior when assigning values in Environment, due to GC

2 participants