Clean up JS-WASM interop: move terminal APIs to xtermConsole.ts by Copilot · Pull Request #189 · RazorConsole/RazorConsole

Copilot · 2025-11-25T05:48:40Z

Original prompt

This section details on the original issue you should resolve

<issue_title>Clean up JS-WASM interop</issue_title>
<issue_description>Currently all the interop lives in main.js and xterm-interop.js under RanzorConsole.Website. Refactoring it to move all apis from main.js and xterm-interop.js to website/src/lib under xtermConsole.ts and only keeps the dotnet-relavent API in original main.js</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Clean up JS-WASM interop #188

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…SM interop Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

github-actions · 2025-11-25T06:10:32Z

🚀 Preview Deployment

A preview build has been generated for this PR from CI run #19662571470!

Download the artifact:
website-preview-189

To view the preview locally:

Download the artifact from the CI workflow run
Extract the ZIP file
Serve the files with a local web server
(e.g., npx serve dist)

🌐 Live Preview URL: https://bba7c35e.razorconsole.pages.dev

The live preview will be automatically updated when you push new
commits to this PR.

LittleLittleCloud

@copilot fix comments

website/src/services/componentRenderer.ts

src/RazorConsole.Website/wwwroot/main.js

…move unused componentRenderer.ts Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Copilot

Pull request overview

This PR refactors the JS-WASM interop layer to establish clearer separation of concerns between terminal manipulation APIs and .NET runtime initialization. Previously, main.js re-exported all terminal functions from xterm-interop.js, creating tight coupling between the WASM runtime and terminal management.

Key Changes

Consolidated terminal APIs: All xterm.js operations (init, write, clear, dispose, attachKeyListener) plus WASM interop functions (registerComponent, handleKeyboardEvent) are now centralized in xtermConsole.ts and exposed via window.razorConsoleTerminal
Simplified main.js: Reduced to a single export (createRuntimeAndGetExports) that returns WASM assembly exports, with all other APIs delegating to window.razorConsoleTerminal
Removed unused files: Deleted xterm-interop.js (functionality moved) and componentRenderer.ts (unused)

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
website/src/services/componentRenderer.ts	Removed unused Blazor component preview renderer service
website/src/lib/xtermConsole.ts	Added `registerTerminalInstance`, `getTerminalInstance`, WASM interop functions (`registerComponent`, `handleKeyboardEvent`), and dynamic import of main.js for WASM exports
website/src/components/XTermPreview.tsx	Updated imports from `"razor-console"` to `"@/lib/xtermConsole"` to use refactored API
website/package-lock.json	Removed unused WASM-related dependencies: `vite-plugin-wasm`, `vite-plugin-top-level-await`, `@swc/core`, `@rollup/plugin-virtual`, and `uuid`
src/RazorConsole.Website/wwwroot/xterm-interop.js	Deleted - all terminal API functionality migrated to xtermConsole.ts
src/RazorConsole.Website/wwwroot/main.js	Refactored to export only `createRuntimeAndGetExports`; terminal APIs now accessed via `window.razorConsoleTerminal`
src/RazorConsole.Website/wwwroot/main.d.ts	Updated type definitions to reflect new API surface: single `createRuntimeAndGetExports` export returning `WasmExports` interface

Files not reviewed (1)

website/package-lock.json: Language not supported

src/RazorConsole.Website/wwwroot/main.js

Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

LittleLittleCloud · 2025-11-25T07:48:03Z

@copilot get this error in preview deploy

Error: Failed to load WASM module from /wasm/wwwroot/main.js: Failed to fetch dynamically imported module: https://5d965bf9.razorconsole.pages.dev/wasm/wwwroot/main.js

Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Copilot · 2025-11-25T07:52:14Z

@copilot get this error in preview deploy

Error: Failed to load WASM module from /wasm/wwwroot/main.js: Failed to fetch dynamically imported module: https://5d965bf9.razorconsole.pages.dev/wasm/ww...

Fixed the WASM module loading issue. The problem was using a dynamic import from /wasm/wwwroot/main.js which doesn't exist at runtime on the deployed site. Changed to use a static import from the razor-console package which is properly bundled by Vite at build time. (5f31f92)

website/src/lib/xtermConsole.ts

…tion Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

…ts (#189)" This reverts commit b2e7243.

…ts (#189)" (#193) This reverts commit b2e7243.

Copilot AI self-assigned this Nov 25, 2025

Initial plan

14b67e7

Copilot AI assigned LittleLittleCloud Nov 25, 2025

Copilot started work on behalf of LittleLittleCloud November 25, 2025 05:49 View session

Copilot AI and others added 2 commits November 25, 2025 05:55

Move terminal APIs from main.js to xtermConsole.ts and clean up JS-WA…

859739a

…SM interop Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Fix JSDoc type reference in main.js

1f45fd0

Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor JS-WASM interop by moving APIs to xtermConsole.ts~~ Clean up JS-WASM interop: move terminal APIs to xtermConsole.ts Nov 25, 2025

Copilot AI requested a review from LittleLittleCloud November 25, 2025 06:00

Copilot finished work on behalf of LittleLittleCloud November 25, 2025 06:00

LittleLittleCloud reviewed Nov 25, 2025

View reviewed changes

website/src/services/componentRenderer.ts Show resolved Hide resolved

src/RazorConsole.Website/wwwroot/main.js Outdated Show resolved Hide resolved

Copilot started work on behalf of LittleLittleCloud November 25, 2025 07:18 View session

Move registerComponent and handleKeyboardEvent to xtermConsole.ts, re…

b5f5849

…move unused componentRenderer.ts Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

LittleLittleCloud marked this pull request as ready for review November 25, 2025 07:25

Copilot AI review requested due to automatic review settings November 25, 2025 07:25

Copilot AI requested a review from LittleLittleCloud November 25, 2025 07:25

Copilot finished work on behalf of LittleLittleCloud November 25, 2025 07:25

Copilot started reviewing on behalf of LittleLittleCloud November 25, 2025 07:25 View session

Copilot finished reviewing on behalf of LittleLittleCloud November 25, 2025 07:29

Copilot AI reviewed Nov 25, 2025

View reviewed changes

src/RazorConsole.Website/wwwroot/main.js Outdated Show resolved Hide resolved

LittleLittleCloud unassigned Copilot Nov 25, 2025

Copilot started work on behalf of LittleLittleCloud November 25, 2025 07:37 View session

Refactor main.js to create dotnet instance only once

529a1c8

Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Copilot finished work on behalf of LittleLittleCloud November 25, 2025 07:40

Copilot started work on behalf of LittleLittleCloud November 25, 2025 07:48 View session

Fix WASM module import by using static import from razor-console package

5f31f92

Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Copilot finished work on behalf of LittleLittleCloud November 25, 2025 07:53

LittleLittleCloud reviewed Nov 25, 2025

View reviewed changes

website/src/lib/xtermConsole.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of LittleLittleCloud November 25, 2025 08:05 View session

Use WasmExports interface from main.d.ts instead of local type defini…

65b3bbc

…tion Co-authored-by: LittleLittleCloud <16876986+LittleLittleCloud@users.noreply.github.com>

Copilot AI requested a review from LittleLittleCloud November 25, 2025 08:09

Copilot finished work on behalf of LittleLittleCloud November 25, 2025 08:09

LittleLittleCloud approved these changes Nov 25, 2025

View reviewed changes

LittleLittleCloud requested a review from TeseySTD November 25, 2025 15:44

TeseySTD approved these changes Nov 25, 2025

View reviewed changes

LittleLittleCloud merged commit b2e7243 into main Nov 25, 2025
12 checks passed

LittleLittleCloud deleted the copilot/clean-up-js-wasm-interop branch November 25, 2025 16:41

github-actions bot added this to the v0.2.0 milestone Nov 25, 2025

LittleLittleCloud added a commit that referenced this pull request Nov 25, 2025

Revert "Clean up JS-WASM interop: move terminal APIs to xtermConsole.…

3f77d2d

…ts (#189)" This reverts commit b2e7243.

LittleLittleCloud mentioned this pull request Nov 25, 2025

Revert "Clean up JS-WASM interop: move terminal APIs to xtermConsole.ts" #193

Merged

LittleLittleCloud added a commit that referenced this pull request Nov 25, 2025

Revert "Clean up JS-WASM interop: move terminal APIs to xtermConsole.…

0bad317

…ts (#189)" (#193) This reverts commit b2e7243.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up JS-WASM interop: move terminal APIs to xtermConsole.ts#189

Clean up JS-WASM interop: move terminal APIs to xtermConsole.ts#189
LittleLittleCloud merged 7 commits intomainfrom
copilot/clean-up-js-wasm-interop

Copilot AI commented Nov 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

LittleLittleCloud left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

LittleLittleCloud commented Nov 25, 2025

Uh oh!

Copilot AI commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Preview Deployment

Uh oh!

LittleLittleCloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

LittleLittleCloud commented Nov 25, 2025

Uh oh!

Copilot AI commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading