[html] convertLazyLoading: Add parseSrcset()#4503
Merged
dvikan merged 3 commits intoRSS-Bridge:masterfrom Mar 31, 2025
Merged
Conversation
Add srcset parser closer to the specifications
Contributor
|
you can typehint function params plese check return value of |
Contributor
Author
|
Done! |
floviolleau
pushed a commit
to floviolleau/rss-bridge
that referenced
this pull request
Aug 18, 2025
* [html] convertLazyLoading: Add parseSrcset() Add srcset parser closer to the specifications * [html] code linting * [html] parseSrcset: Add type hints, check preg_match_all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
convertLazyLoading()function converts lazy loading images with multiple sources (e.g.srcsetattribute) back to regular<img>elements with a fixedsrcURL for use by feed readers. Currently, it simply separate fields by splitting by comma, but properly parsingsrcsetthe attribute is more tricky that it seems, because URLs can also contain commas like this:This PR aims at implementing
srcsetparsing closer to the specifications to properly retrieve the largest image.https://html.spec.whatwg.org/multipage/images.html#parse-a-srcset-attribute