Skip to content

[ManyVidsBridge] Fix parsing of URL input#4499

Merged
dvikan merged 1 commit intoRSS-Bridge:masterfrom
subtle4553:manyvidsbridge-fix-url-as-parameter
Mar 27, 2025
Merged

[ManyVidsBridge] Fix parsing of URL input#4499
dvikan merged 1 commit intoRSS-Bridge:masterfrom
subtle4553:manyvidsbridge-fix-url-as-parameter

Conversation

@subtle4553
Copy link
Contributor

I fixed problems with the feed when the user uses a full URL as input:

  • The regex didn't recognize profile names that include dashes.
  • I made the use of www. in the URL optional.
  • Some URLs in the generated feed were incorrect which led me to clean up the code some more.

Other fixes and changes

  • I fixed a typo in the name of the profile parameter.
  • I now better understand the flow of bridge classes and realized that the caching functions I made aren't necessary. So, I removed them and now I instead collect all data in collectData and store them in properties if I need them in one of the getter methods (getName, getUri, etc.). That way the code way more straight forward.
  • I also added type declarations.

@github-actions
Copy link

Pull request artifacts

Bridge Context Status
ManyVids 1 untitled (current) ⚠️ The feed has no items
ManyVids 1 untitled (pr) ⚠️ The feed has no items

last change: Thursday 2025-03-27 14:09:02

@dvikan dvikan merged commit 3055e69 into RSS-Bridge:master Mar 27, 2025
9 checks passed
@subtle4553 subtle4553 deleted the manyvidsbridge-fix-url-as-parameter branch March 28, 2025 02:43
floviolleau pushed a commit to floviolleau/rss-bridge that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants