[RedditBridge] Added time interval and filter for min comment count#4471
Merged
dvikan merged 4 commits intoRSS-Bridge:masterfrom Mar 23, 2025
Merged
[RedditBridge] Added time interval and filter for min comment count#4471dvikan merged 4 commits intoRSS-Bridge:masterfrom
dvikan merged 4 commits intoRSS-Bridge:masterfrom
Conversation
Pull request artifacts
last change: Sunday 2025-03-23 19:41:45 |
Contributor
|
i dont understand the purpose of having if, elseif, elseif for filtering on score and comment count |
Contributor
|
anyways, it works... |
Contributor
Author
I thought it made more sense, if both a minimum score and minimum number of comments are provided, the filter does an OR between these 2 conditions rather than an AND (e.g. if a post gets a lot of comments but not a lot of upvotes, it probably has an interesting discussion that might be worth seeing). |
floviolleau
pushed a commit
to floviolleau/rss-bridge
that referenced
this pull request
Aug 18, 2025
…SS-Bridge#4471) * Reddit Bridge - added filter for min comment count and time interval. * [RedditBridge] Add sort by comment count * lint * consistent commas --------- Co-authored-by: Dag <me@dvikan.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the 'top' sorting order for reddit, most times you want to limit to a time interval (e.g. top in the last month). In the search UI, there is a time interval filter that will end up as a query parameter
t=interval.Also, added filtering and sorting by comment count.