Conversation
Instead of storing logs inside the container (where then cannot easily be seen not rotated), consider using the standard Docker approach of writing to standard output https://docs.docker.com/config/containers/logging/
|
P.S. Ah, it is another regression due to #2721 It used to be correct as it was using a production-ready base-image https://github.com/docker-library/php/blob/3dc959846f1d44d6c3200f657dee762885847a2c/8.2/buster/apache/Dockerfile#L84-L87 |
|
Aha. Maybe just omit the |
|
I have not tested, but I believe omitting those lines would use default global values, which are not that |
|
Change is fine, I just tested it locally. Will reroute logs to stdout and stderr to be read by |
|
I did some thinking. I think it's better to make this configurable by env variable. Keep the default logs as it is, add an env variable "rsslogging=docker" or so to sed the path in nginx. I assume that there are people out there that have mounted their logfiles to the host to have them analyzed by awstats/goaccess or so. It would break those setups and require us to then make the other approach optional. Can you redo the PR to check for an env variable and replace the text in nginx.conf if its set? you can use the docker entrypoint script |
|
The breaking change came with #2721 as it used to be correct before (that PR did break my setup). |
|
Alright I think we should go for writing to stdout/stderr by default in the docker container. Remember that we are talking about the nginx processes here. We can write to files from within the php app if we really want to. Regarding @Bockiii concern, we can make a note about this change in the next release. Who wants to make a pr? |
|
oh lol this is a pr. Im gonna merge |
* Fix expose RSS-Bridge#3234 * Re-fix better logs RSS-Bridge#3333 * Update to Debian 12 Bookworm instead of Debian 10 Buster * Use Debian packaging instead of having to keep track of and manually install -dev libraries, and with LTS support * Update to PHP 8.2 instead of PHP 8.0
|
Reworked in #3500 to use the same approach than https://github.com/docker-library/php/blob/3dc959846f1d44d6c3200f657dee762885847a2c/8.2/buster/apache/Dockerfile#L84-L87 |
* Docker from Debian base image * Fix expose #3234 * Re-fix better logs #3333 * Update to Debian 12 Bookworm instead of Debian 10 Buster * Use Debian packaging instead of having to keep track of and manually install -dev libraries, and with LTS support * Update to PHP 8.2 instead of PHP 8.0 * Fix php.ini location * Minor order changes To optimise caching
Instead of storing logs inside the container (where they cannot easily be seen nor rotated), consider using the standard Docker approach of writing to standard output https://docs.docker.com/config/containers/logging/