Skip to content

[UberNewsroomBridge] Add bridge#2748

Merged
Bockiii merged 8 commits intoRSS-Bridge:masterfrom
VerifiedJoseph:UberNewsroomBridge
May 25, 2022
Merged

[UberNewsroomBridge] Add bridge#2748
Bockiii merged 8 commits intoRSS-Bridge:masterfrom
VerifiedJoseph:UberNewsroomBridge

Conversation

@VerifiedJoseph
Copy link
Contributor

Adds bridge for https://www.uber.com/newsroom/

Closes #2744

@github-actions
Copy link

github-actions bot commented May 24, 2022

Pull request artifacts

file last change
UberNewsroom-pr-context1 2022-05-25, 07:42:04

@Bockiii
Copy link
Contributor

Bockiii commented May 24, 2022

Hey,

thanks!

two questions:

  • The preview seems to format a "Registered" sign into the code. Is that because of the test or does the same behavior happen on your end as well?
  • Have you tried finding an URL that might already generate the RSS feed on their end? It looks like wordpress is working and generating a few of the things it should, maybe we are just missing the rss feed endpoint.

@VerifiedJoseph
Copy link
Contributor Author

  • The preview seems to format a "Registered" sign into the code. Is that because of the test or does the same behavior happen on your end as well?

I can't replicate this. Do you have an example?

  • Have you tried finding an URL that might already generate the RSS feed on their end? It looks like wordpress is working and generating a few of the things it should, maybe we are just missing the rss feed endpoint.

Haven't found one. Looks like they are using WordPress but with a custom front-end.

@Bockiii
Copy link
Contributor

Bockiii commented May 24, 2022

Check the preview. But that's on me, I'm not checking for nested lists. I will fix that in the preview script

1 similar comment
@Bockiii
Copy link
Contributor

Bockiii commented May 24, 2022

Check the preview. But that's on me, I'm not checking for nested lists. I will fix that in the preview script

@VerifiedJoseph
Copy link
Contributor Author

Check the preview. But that's on me, I'm not checking for nested lists. I will fix that in the preview script

So it does, how odd.

image

Firefox and chrome read &reg as the HTML Entity for registered trademark symbol (®). Using htmlentities() on the $_SERVER['QUERY_STRING'] in lib/Exceptions.php (line 89) fixes that.

@VerifiedJoseph VerifiedJoseph marked this pull request as ready for review May 24, 2022 16:07
@Bockiii
Copy link
Contributor

Bockiii commented May 24, 2022

No, it's actually just not processing the list at all and result is just wrong, so there's no other function that's needed :)

@Bockiii
Copy link
Contributor

Bockiii commented May 25, 2022

Tadaa... now the preview works as well.

Bridge looks good to me. Maybe someone will find an rss endpoint at some point, but until then: Thanks!

@Bockiii Bockiii merged commit 85e5ce2 into RSS-Bridge:master May 25, 2022
@VerifiedJoseph VerifiedJoseph deleted the UberNewsroomBridge branch June 5, 2022 22:26
IAM-marco pushed a commit to IAM-marco/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bridge request for Uber Newsroom

2 participants