Skip to content

[CubariBridge] New Bridge#2747

Merged
Bockiii merged 10 commits intoRSS-Bridge:masterfrom
KamaleiZestri:cubari
May 24, 2022
Merged

[CubariBridge] New Bridge#2747
Bockiii merged 10 commits intoRSS-Bridge:masterfrom
KamaleiZestri:cubari

Conversation

@KamaleiZestri
Copy link
Contributor

Cubari is an image proxy site that is used to give a custom UI made for manga reading to pretty much whatever image files are given to it.
One format for the site to take in an entire manga series is by a specially formatted JSON file.
This bridge converts those JSON files into RSS.

@github-actions
Copy link

github-actions bot commented May 22, 2022

Pull request artifacts

file last change
Cubari-pr-context1 2022-05-24, 02:23:57

Copy link
Contributor

@yamanq yamanq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this! Do you have examples for the other urls you described for testing? (gist/ and gitio shortcode)

KamaleiZestri and others added 2 commits May 22, 2022 20:59
Co-authored-by: Yaman Qalieh <ybq987@gmail.com>
Co-authored-by: Yaman Qalieh <ybq987@gmail.com>
@KamaleiZestri
Copy link
Contributor Author

An example with gist prefix instead of raw would be
https://gist.githubusercontent.com/funkyhippo/1d40bd5dae11e03a6af20e5a9a030d81/raw/

In hindsight, I probably should have removed the bit about git.io. Git.io was essentially a url shortener that is now defunct. It doesn't even effect how the bridge works, I just had it for initially creating the bridge and testing if it would cause issues. It doesn't.

Reddit post on cubari URLs from one of the devs:
https://old.reddit.com/r/manga/comments/s1x668/sl_cubarimoe_gist_links_are_now_deprecated/

@Bockiii
Copy link
Contributor

Bockiii commented May 23, 2022

Interesting what kind of stuff some sites do...

Anyways, the articles are not sorted by timestamp, I assume they should be?
The only link to the article is the title, depending on the reader, you might also want to add the link to the content (as you already have the title, maybe put the link there)

@Bockiii
Copy link
Contributor

Bockiii commented May 24, 2022

LGTM, ready to merge @KamaleiZestri ?

@KamaleiZestri
Copy link
Contributor Author

Yes. Has everything I can think of right now.

@Bockiii Bockiii merged commit 4623193 into RSS-Bridge:master May 24, 2022
senrou added a commit to senrou/rss-bridge that referenced this pull request May 24, 2022
IAM-marco pushed a commit to IAM-marco/rss-bridge that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants