[PixivBridge] Add User context#2650
Merged
dvikan merged 1 commit intoRSS-Bridge:masterfrom May 8, 2022
Merged
Conversation
Pull request artifacts
|
Contributor
Author
|
I'm not sure how to maintain backwards compatibility while allowing the tests to pass. |
Contributor
|
I tested with an existing feed url and this PR does not break old urls. Thats good. |
Contributor
Author
|
Yes, I coded it to be backwards compatible. However, this makes the tests (specifically the linting tests) fail. |
Contributor
|
There is a unit test that disallows context to be the empty string. I don't see a good reason for that. And in this case we actually do want that. I don't understand how it preserves BC, but it does. I suggest remove test. EDIT: I excluded Pixiv for this particular assertion. |
IAM-marco
pushed a commit
to IAM-marco/rss-bridge
that referenced
this pull request
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost a rewrite of the bridge so that it better handles multiple contexts. One important note is that the maximum number of posts returned is now decreased if selecting a specific Post Type, but this limit is still 24 for illustrations/manga and 8 for novels, which I think is high enough for almost all use cases. I also added a new Post Type, "All" which aggregates results from all types.
Closes #2635