feat: add a timeout option for http client#2600
feat: add a timeout option for http client#2600dvikan merged 2 commits intoRSS-Bridge:masterfrom dvikan:curl-timeout
Conversation
|
Which problem adresses this? |
|
This change makes it possible to configure a default value for how long curl waits before considering it a network failure. Right now it waits 60 seconds before timing out. In my automatic testing I want to lower this threshold to maybe 10 seconds. But a bridge instance might want to have a different default timeout value. In any case, each bridge can override this timeout value in their call to |
|
So it's keeping the current default while adding a config option? Okay, sounds good. Can you add some documentation for this to the /docs section? Thanks |
|
Yeah the prior value was |
|
LGTM! |
|
I think that eventually we want to lower this value when we introduce retry logic. E.g. if it times out for 15s, it aborts and tries again. That's for a later concern though. Ideally it has retry logic by default, which can be turned off from the client call. |
No description provided.