[PhoronixBridge] support multipage and embed benchmarks#2522
Merged
Bockiii merged 5 commits intoRSS-Bridge:masterfrom Mar 27, 2022
Merged
[PhoronixBridge] support multipage and embed benchmarks#2522Bockiii merged 5 commits intoRSS-Bridge:masterfrom
Bockiii merged 5 commits intoRSS-Bridge:masterfrom
Conversation
Contributor
|
You can ignore the linting error about donnonsbridge, there was an error in merging another PR. You dont have linting errors with your bridge. |
Contributor
Author
|
I ran phpcs prior to submitting. I had one puzzling situation, with the |
Bockiii
reviewed
Mar 25, 2022
| protected function parseItem($newsItem){ | ||
| $item = parent::parseItem($newsItem); | ||
| // $articlePage gets the entire page's contents | ||
| $articlePage = getSimpleHTMLDOM($newsItem->link); |
Contributor
There was a problem hiding this comment.
Suggested change
| $articlePage = getSimpleHTMLDOM($newsItem->link); | |
| $articlePage = getSimpleHTMLDOM($newsItem->link); | |
| $articlePage = defaultLinkTo($articlePage, $this->getURI()); |
Contributor
There was a problem hiding this comment.
this should fix the issue that the posts have a category image which's link is relative:
Contributor
Author
There was a problem hiding this comment.
Thanks for the review and the suggestion. I didn't notice this because TT-RSS was doing the job itself…
🤖 Pull request artifacts
|
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bridge now supports multipage article. In those article, benchmarks from OpenBenchmarking.com are now embedded, either as SVG in
<object>tag or as<img>. The second option is useful for feed readers like TT-RSS that disable<object>or<svg>tags for security reasons.