add support for more media types as enclosures, handle result of /tex…#2324
Merged
dvikan merged 4 commits intoRSS-Bridge:masterfrom Mar 24, 2022
Merged
Conversation
…t() xpath expressions
95274ac to
c99b1db
Compare
em92
reviewed
Nov 6, 2021
lib/XPathAbstract.php
Outdated
Comment on lines
+533
to
+535
| protected function cleanImageUrl($imageUrl) | ||
| { | ||
| $result = preg_match('~(?:http(?:s)?:)?[\/a-zA-Z0-9\-_\.]+\.(?:jpg|gif|png|jpeg|ico){1}~', $imageUrl, $matches); | ||
| $result = preg_match('~(?:http(?:s)?:)?[\/a-zA-Z0-9\-_\.]+\.(?:jpg|gif|png|jpeg|ico|mp3){1}~', $imageUrl, $matches); |
Contributor
There was a problem hiding this comment.
looks like cleanImageUrl should be renamed to cleanMediaUrl. Same about parameter.
Contributor
|
Hey, @Niehztog! Left comment above. |
Contributor
Author
|
Hello @em92 , thank you for your feedback, I changed my code accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @em92
here come two small fixes for class XPathAbstract:
/text()XPath function (they might return instanctes ofDOMText)