Closed
Conversation
VerifiedJoseph
suggested changes
Aug 7, 2021
Contributor
VerifiedJoseph
left a comment
There was a problem hiding this comment.
Nice bridge. Just a few suggestions and pointers.
bridges/HashnodeBridge.php
Outdated
Comment on lines
+14
to
+18
| $url = self::URI . '/' . $this->getInput('sort'); | ||
|
|
||
| $html = getSimpleHTMLDOM($url) | ||
| or returnServerError('Error while downloading the website content'); | ||
|
|
Contributor
There was a problem hiding this comment.
Is this needed? The HTML is not used when creating items.
Suggested change
| $url = self::URI . '/' . $this->getInput('sort'); | |
| $html = getSimpleHTMLDOM($url) | |
| or returnServerError('Error while downloading the website content'); |
Co-authored-by: Joseph <joseph@verifiedjoseph.com>
Co-authored-by: Joseph <joseph@verifiedjoseph.com>
Co-authored-by: Joseph <joseph@verifiedjoseph.com>
Contributor
Author
|
@VerifiedJoseph you right! Thanks! |
Contributor
|
Tested locally. Works fine. Should be easy to add author too: |
dvikan
added a commit
that referenced
this pull request
Mar 24, 2022
Contributor
|
Added in 50bab07 |
IAM-marco
pushed a commit
to IAM-marco/rss-bridge
that referenced
this pull request
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.