Skip to content

[FurAffinityUserBridge] Replate username/password with cookie login#1641

Merged
Bockiii merged 5 commits intoRSS-Bridge:masterfrom
girlpunk:fix-fauser-login
Mar 31, 2022
Merged

[FurAffinityUserBridge] Replate username/password with cookie login#1641
Bockiii merged 5 commits intoRSS-Bridge:masterfrom
girlpunk:fix-fauser-login

Conversation

@girlpunk
Copy link
Contributor

@girlpunk girlpunk commented Jul 5, 2020

Current FurAffinity bridge no longer (or possibly never) logs in as the user, rendering some content inaccessible.

As a captcha has now been added to the login page, the only viable way of accessing this content is by having the user log in via a browser, then copy the session cookies. As found in #1083 these cookies do not expire.

@girlpunk
Copy link
Contributor Author

girlpunk commented Jul 5, 2020

Not entirely sure what the CI wants me to do with that string. Too long to go on one line but can't have a join to put it on two lines.

@somini
Copy link
Contributor

somini commented Jul 14, 2020

This kind of thing is probably better handled by #1170 or similar. But it's grandfathered in, so LGTM.

CI can be a little finicky...

@dvikan
Copy link
Contributor

dvikan commented Mar 24, 2022

@girlpunk Please fix conflict.

@dvikan
Copy link
Contributor

dvikan commented Mar 29, 2022

@girlpunk Can you check if this PR is still good?

@girlpunk
Copy link
Contributor Author

girlpunk commented Mar 29, 2022

As far as I know, should still be good. I've fixed the merge conflict too.

@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

Pull request artifacts

file last change
FurAffinityUser-current-context1 2022-03-31, 18:19:46
FurAffinityUser-pr-context1 2022-03-31, 18:19:46

@dvikan
Copy link
Contributor

dvikan commented Mar 29, 2022

Alright I don't have account so can't test. Can you fix the phpcs complaint?

@girlpunk
Copy link
Contributor Author

girlpunk commented Mar 29, 2022

Not entirely sure what phpcs wants to fix this one?

@Bockiii
Copy link
Contributor

Bockiii commented Mar 29, 2022 

FILE: ...ner/work/rss-bridge/rss-bridge/bridges/FurAffinityUserBridge.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 6 | ERROR | Line exceeds maximum limit of 1[20](https://github.com/RSS-Bridge/rss-bridge/runs/5743606466?check_suite_focus=true#step:4:20) characters; contains
   |       | 201 characters
----------------------------------------------------------------------

@Bockiii
Copy link
Contributor

Bockiii commented Mar 29, 2022

The description line is long a.f.

@Bockiii
Copy link
Contributor

Bockiii commented Mar 29, 2022

Idea:
Create a new file in /docs/10_Bridge_Specific similar to the Instagram file that's in there and describe how to get the cookie. Then, in the description just say "Please see link on how to use this"

@Bockiii Bockiii mentioned this pull request Mar 31, 2022
Merged
Bockiii
Bockiii reviewed Mar 31, 2022
View reviewed changes
@Bockiii
Copy link
Contributor

Bockiii commented Mar 31, 2022

Now it should be good. All checks passed, I created the how-to in the docs folder. Done

@Bockiii Bockiii merged commit d6695c0 into RSS-Bridge:master Mar 31, 2022
@Bockiii
Copy link
Contributor

Bockiii commented Mar 31, 2022

ping back to #2553

@girlpunk girlpunk deleted the fix-fauser-login branch March 31, 2022 20:02
IAM-marco pushed a commit to IAM-marco/rss-bridge that referenced this pull request Jun 17, 2022
@girlpunk @IAM-marco
[FurAffinityUserBridge] Replate username/password with cookie login (R…
569eb28 
…SS-Bridge#1641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bockiii Bockiii Bockiii left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@girlpunk @somini @dvikan @Bockiii