Skip to content

[StanfordSIRbookreview Bridge] - Add new bridge#1638

Closed
Kidman1670 wants to merge 7 commits intoRSS-Bridge:masterfrom
Kidman1670:ssir-book
Closed

[StanfordSIRbookreview Bridge] - Add new bridge#1638
Kidman1670 wants to merge 7 commits intoRSS-Bridge:masterfrom
Kidman1670:ssir-book

Conversation

@Kidman1670
Copy link

@Kidman1670 Kidman1670 commented Jul 4, 2020

magikarpbaby added 3 commits July 4, 2020 09:45
test
2a948ea
0.1
cf48d72
add StandfordSIRbookreviewBridge
018e0c4 
add StandfordSIRbookreviewBridge
@Kidman1670 Kidman1670 changed the title Ssir book - StanfordSIRbookreview Bridge [StanfordSIRbookreview Bridge] - Add new bridge Jul 4, 2020
@somini
Copy link
Contributor

somini commented Jul 14, 2020

Is this different from:

@Kidman1670
Copy link
Author

Kidman1670 commented Jul 15, 2020

Is this different from:

* https://ssir.org/site/rss_2.0

* https://ssir.org/blog/rss

yes?! , please just spend some minutes to see different in number of articles from ssir.org/* and ssir.org/book/*. Book review is all I care that why I make this bridge.

@somini
Copy link
Contributor

somini commented Jul 16, 2020

Very well, just checking that you were aware of those feeds. LGTM, once you fix that message above. 😄

@Kidman1670
Copy link
Author

Kidman1670 commented Jul 16, 2020

Very well, just checking that you were aware of those feeds. LGTM, once you fix that message above. smile

I don't understand your sentences yet, sorry if my english skill is not good enough.
What is LGTM? (is it in https://www.urbandictionary.com/define.php?term=LGTM)
and what is "that message above"?

@somini
Copy link
Contributor

somini commented Jul 17, 2020

What is LGTM? (is it in https://www.urbandictionary.com/define.php?term=LGTM)

Sorry, I should have explained it better. Looks Good To Me.
I commented on the message above, I was referring to the "returnServerError" error on the code.

Update StanfordSIRbookreviewBridge.php
c60ced7 
Fix some minor mistake.
@Kidman1670
Copy link
Author

Kidman1670 commented Jul 17, 2020

What is LGTM? (is it in https://www.urbandictionary.com/define.php?term=LGTM)

Sorry, I should have explained it better. Looks Good To Me.
I commented on the message above, I was referring to the "returnServerError" error on the code.

Ah, sorry. This is my fault. Thank you very much

dvikan added a commit that referenced this pull request Mar 22, 2022
@dvikan
feat: add new bridge StandfordSIRbookreviewBridge (#1638)
14a7516
@dvikan
Copy link
Contributor

dvikan commented Mar 22, 2022

14a7516

@dvikan dvikan closed this Mar 22, 2022
IAM-marco pushed a commit to IAM-marco/rss-bridge that referenced this pull request Jun 17, 2022
@dvikan @IAM-marco
feat: add new bridge StandfordSIRbookreviewBridge (RSS-Bridge#1638)
a6ed36f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kidman1670 @somini @dvikan