Merged
Conversation
- Implements a simple "published books by author" bridge. - Uses URL as input - Returns all published books
Contributor
|
Can you verify this still works? |
Contributor
|
I tested. It's broken for author and url. @captn3m0 |
Contributor
Author
|
I'll check this and #1349 for bugs 👍 |
Contributor
|
@captn3m0 Ping |
Contributor
Author
|
Will take me a while to get to checking on this. Would like to keep this open, if that's fine. |
Bockiii
reviewed
Apr 5, 2022
Pull request artifacts
|
Bockiii
reviewed
Apr 5, 2022
Contributor
Bockiii
left a comment
There was a problem hiding this comment.
Add tabs instead of spaces
Contributor
|
Sheesh... using the github UI isnt great for these kinds of fixes. I'm most of the way there @captn3m0 . Can you do the rest of the linting and phpunit fixes? Then we can merge this. Thanks |
Contributor
|
I fixed it since captnemo is MIA :) |
Contributor
Author
|
Thanks a ton @Bockiii 🥇 |
IAM-marco
pushed a commit
to IAM-marco/rss-bridge
that referenced
this pull request
Jun 17, 2022
|
Thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of requests on the Goodreads developer forums for better RSS feeds:
A lot of the old RSS feeds are broken/unmaintained as well. As of now, this implements a single RSS feed to fetch all books by an author.
The usecase is to get notified when a new book by an author is published. If you turn off the "published_only" filter, then you get notified when a new book by an author is announced.
I'm using a specific context, because I want to add more RSS feeds to this, and don't want to break existing links when we do.