Skip to content

Addition of a DEPLOY_COMPRESSION option to the configuration#592

Merged
XECDesign merged 9 commits intoRPi-Distro:masterfrom
gromain:deploy_gz
Mar 1, 2022
Merged

Addition of a DEPLOY_COMPRESSION option to the configuration#592
XECDesign merged 9 commits intoRPi-Distro:masterfrom
gromain:deploy_gz

Conversation

@gromain
Copy link
Contributor

@gromain gromain commented Feb 17, 2022

This PR creates a DEPLOY_GZ option available to use in the config file.
This is turned off by default, and will only work if DEPLOY_ZIP=0.

As it says on the tin, this addition provides a way to produce compressed images in a gzip format.

pigz is used to create the image as it allows the computation to be made using all the available cores, leading to a faster compression stage. It has thus been added to depends.

@XECDesign
Copy link
Member

There has also been talk of switching the official images over to .xz. How about a DEPLOY_COMPRESSION=gz/xz/zip/none type of parameter to avoid having multiple DEPLOY_$format variables in the future?

@gromain
Copy link
Contributor Author

gromain commented Feb 17, 2022

Oh, that would make a lot of sense!
Is there someone working on it? Do you want me to give it a go?

@XECDesign
Copy link
Member

Nobody working on it right now, no. If you'd like to, yeah that would be great. It's not looking like I'd get around to it in the near future myself.

@gromain gromain force-pushed the deploy_gz branch 2 times, most recently from 74f2a7b to 9b664e7 Compare February 17, 2022 12:48
@gromain gromain changed the title Addition of a DEPLOY_GZ option to the configuration Addition of a DEPLOY_COMPRESSION option to the configuration Feb 17, 2022
@gromain
Copy link
Contributor Author

gromain commented Feb 17, 2022

I've pushed some changes to support DEPLOY_COMPRESSION.
I haven't had the time to test those changes yet, so this is still a WIP as far as I'm concerned. It should work though.

@gromain
Copy link
Contributor Author

gromain commented Feb 20, 2022

I'm doing the latest tests now, but it seems all is working well, with gz, xz, zip and none being the available images format supported.

@gromain
Copy link
Contributor Author

gromain commented Feb 21, 2022

All good on my side for this PR.
Build works perfectly with every settings (gz, xz, zip and none, with zip being the default).

@XECDesign
Copy link
Member

I'll test it a little bit when I get a chance, just to double check everything, but I think it's good to go. Thanks for your work on this.

@gromain
Copy link
Contributor Author

gromain commented Feb 22, 2022

No worries, I think it's good to battle test it before creating any problems!
And my pleasure, thanks for your work on pi-gen! ;-)

@XECDesign XECDesign merged commit 5d044ba into RPi-Distro:master Mar 1, 2022
@XECDesign
Copy link
Member

Many thanks!

@gromain gromain deleted the deploy_gz branch March 1, 2022 16:26
oschrenk added a commit to oschrenk/pi-gen that referenced this pull request Mar 4, 2022
* upstream/master: (71 commits)
  Addition of a `DEPLOY_COMPRESSION` option to the configuration (RPi-Distro#592)
  Fix fstab flush option
  Fix whitespace
  Add flush option to boot partition
  Add more binfmt errors and hints to README
  Provide information to build the 64 bit image in the README (RPi-Distro#596)
  fix dash in README
  Update release notes
  Add gpg dependency
  Add check and warning for a space presence in the base path
  Strip trailing spaces
  Fix docker build with debian bullseye image
  Update release notes
  Install ca-certificates during bootstrap
  Don't try to use qemu-debootstrap
  Use trusted.gpg.d instead of apt-key
  Add 7z and zip support
  Update release notes
  stage3: install gnome-keyring
  Install mkvtoolnix for mkvmerge
  ...
scuciurean referenced this pull request in analogdevicesinc/adi-kuiper-gen Mar 23, 2022
mzwinz pushed a commit to zworpor/pi-gen that referenced this pull request Apr 19, 2022
SRaus referenced this pull request in analogdevicesinc/adi-kuiper-gen May 30, 2023
SRaus referenced this pull request in analogdevicesinc/adi-kuiper-gen May 30, 2023
wandering-andy pushed a commit to wandering-andy/pi-gen that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants