HIP build corrections#36
Conversation
r-abishek
commented
Oct 28, 2020
- Fix HIP backend issues
- Changes for hip build
- Change cmakelists for linking issues
- Change include hip/hip_hcc.h to hip/hip_ext.h to avoid warning
Fix pln1 issues in testsuite Fix other minor bugs
|
Issues
======
+ Solved 3
Clones removed
==============
+ src/modules/hip/hip_morphological_transforms.cpp -17
+ src/modules/hip/hip_color_model_conversions.cpp -27
+ src/modules/hip/hip_imgaugmentation.cpp -19
+ src/modules/hip/hip_filter_functions.cpp -6
See the complete overview on Codacy |
|
@LakshmiKumar23 can you check this PR |
LakshmiKumar23
left a comment
There was a problem hiding this comment.
@kiritigowda builds successfully on both rocm3.7 and rocm3.8
rrawther
left a comment
There was a problem hiding this comment.
A lot of functions with commented code and returning SUCCESS. It is better to remove those if not needed anymore.
| stdDev | ||
| ); | ||
| } | ||
| // int ctr=0; |
There was a problem hiding this comment.
if we are not using these implementations anymore, it is better to remove the entire function
There was a problem hiding this comment.
For all the commented functions in this file
| // gDim3[2] = 1; | ||
| // cl_kernel_implementer (handle, gDim3, NULL/*Local*/, theProgram, theKernel); | ||
| } | ||
| // srand(time(0)); |
There was a problem hiding this comment.
Is this not used anymore? Better to remove the function all together
| kernelSize | ||
| ); | ||
| } | ||
| // int ctr=0; |
There was a problem hiding this comment.
please remove all the irrelevant code
…or_mods Resize Bilinear : Tensor Code clean up